Bug 233168 - Use IOHIDEvent timestamps for momentum velocity computation
Summary: Use IOHIDEvent timestamps for momentum velocity computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-15 20:38 PST by Simon Fraser (smfr)
Modified: 2021-11-16 14:06 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.51 KB, patch)
2021-11-15 20:40 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-11-15 20:38:30 PST 
Use IOHIDEvent timestamps for momentum velocity computation
Comment 1 Simon Fraser (smfr) 2021-11-15 20:40:17 PST 
Created attachment 444338 [details]
Patch
Comment 2 Tim Horton 2021-11-15 21:51:55 PST 
Comment on attachment 444338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444338&action=review

> Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:-340
> -    LOG_WITH_STREAM(ScrollAnimations, stream << "ThreadedScrollingTree::willStartRenderingUpdate - scrollingThreadIsActive " << scrollingThreadIsActive());

Where'd this go?
Comment 3 Simon Fraser (smfr) 2021-11-16 13:57:45 PST 
(In reply to Tim Horton from comment #2)
> Comment on attachment 444338 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444338&action=review
> 
> > Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:-340
> > -    LOG_WITH_STREAM(ScrollAnimations, stream << "ThreadedScrollingTree::willStartRenderingUpdate - scrollingThreadIsActive " << scrollingThreadIsActive());
> 
> Where'd this go?

It annoyed me so I removed it.
Comment 4 EWS 2021-11-16 14:05:08 PST 
Committed r285883 (244308@main): <https://commits.webkit.org/244308@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444338 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-16 14:06:25 PST 
<rdar://problem/85474517>