Bug 23316 - Application cache updating always fails with an assertion
Summary: Application cache updating always fails with an assertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 06:45 PST by Alexey Proskuryakov
Modified: 2009-01-14 09:59 PST (History)
0 users

See Also:

Attachments
proposed patch (8.23 KB, patch)
2009-01-14 06:49 PST, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-01-14 06:45:14 PST 
The assertion is bogus. A patch that will also fix a related crash is forthcoming.
Comment 1 Alexey Proskuryakov 2009-01-14 06:49:40 PST 
Created attachment 26706 [details]
proposed patch
Comment 2 Darin Adler 2009-01-14 09:24:25 PST 
Comment on attachment 26706 [details]
proposed patch

> +    // Release our reference to the newest cache. This could cause us to be deleted.
> +    // Any ongoing updates will be stopped from destructor.
> +    m_savedNewestCachePointer = m_newestCache.release().get();

I think it would be clearer to write this like this:

    m_savedNewestCachePointer = m_newestCache.get();
    m_newestCache.clear();

That's because release() is a function used to transfer ownership, and we're really not doing that.

r=me
Comment 3 Alexey Proskuryakov 2009-01-14 09:59:25 PST 
Committed revision 39891.