Bug 233151 - Adjust graphics related message filter
Summary: Adjust graphics related message filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-15 14:51 PST by Per Arne Vollan
Modified: 2021-11-18 11:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2021-11-15 14:55 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2021-11-16 10:58 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2021-11-16 11:02 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2021-11-16 14:08 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-11-15 14:51:55 PST 
Adjust graphics related message filter in the WebContent process on iOS.
Comment 1 Per Arne Vollan 2021-11-15 14:55:52 PST 
Created attachment 444309 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-11-15 15:01:38 PST 
<rdar://problem/85430575>
Comment 3 Per Arne Vollan 2021-11-16 10:58:25 PST 
Created attachment 444410 [details]
Patch
Comment 4 Per Arne Vollan 2021-11-16 11:02:00 PST 
Created attachment 444413 [details]
Patch
Comment 5 Brent Fulgham 2021-11-16 11:25:04 PST 
Comment on attachment 444413 [details]
Patch

r=me
Comment 6 Per Arne Vollan 2021-11-16 11:29:29 PST 
Comment on attachment 444413 [details]
Patch

Thanks for reviewing!
Comment 7 EWS 2021-11-16 12:20:53 PST 
Committed r285878 (244304@main): <https://commits.webkit.org/244304@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444413 [details].
Comment 8 Per Arne Vollan 2021-11-16 14:08:49 PST 
Reopening to attach new patch.
Comment 9 Per Arne Vollan 2021-11-16 14:08:50 PST 
Created attachment 444426 [details]
Patch
Comment 10 Brent Fulgham 2021-11-16 14:10:25 PST 
Comment on attachment 444426 [details]
Patch

r=me
Comment 11 Per Arne Vollan 2021-11-16 14:20:13 PST 
Comment on attachment 444426 [details]
Patch

Thanks for reviewing!
Comment 12 EWS 2021-11-16 14:54:06 PST 
Committed r285889 (244311@main): <https://commits.webkit.org/244311@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444426 [details].
Comment 13 Alexey Proskuryakov 2021-11-18 11:40:21 PST 
Comment on attachment 444426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444426&action=review

> Source/WebKit/ChangeLog:9
> +        Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies

This patch doesn't touch the iOS profile, which is in Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in. So seems like either the comment or the patch is incorrect?

I do see that there is another patch in this bug that does touch iOS; my question is about this patch that was landed too.
Comment 14 Per Arne Vollan 2021-11-18 11:49:52 PST 
(In reply to Alexey Proskuryakov from comment #13)
> Comment on attachment 444426 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444426&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies
> 
> This patch doesn't touch the iOS profile, which is in
> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.
> in. So seems like either the comment or the patch is incorrect?
> 
> I do see that there is another patch in this bug that does touch iOS; my
> question is about this patch that was landed too.

Yes, you're right, the Change log comment is incorrect here, since the second patch only touches macOS.

Thanks for reviewing!