Bug 233134 - Remove some dead code from IPC::Encoder / IPC::Decoder
Summary: Remove some dead code from IPC::Encoder / IPC::Decoder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-15 09:52 PST by Chris Dumez
Modified: 2021-11-15 12:06 PST (History)
7 users (show)

See Also:


Attachments
Patch (6.25 KB, patch)
2021-11-15 09:54 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-15 09:52:39 PST
Remove some dead code from IPC::Encoder / IPC::Decoder.
Comment 1 Chris Dumez 2021-11-15 09:54:00 PST
Created attachment 444268 [details]
Patch
Comment 2 EWS 2021-11-15 11:20:00 PST
Committed r285818 (244260@main): <https://commits.webkit.org/244260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444268 [details].
Comment 3 Radar WebKit Bug Importer 2021-11-15 11:23:44 PST
<rdar://problem/85421330>
Comment 4 Darin Adler 2021-11-15 12:06:29 PST
Comment on attachment 444268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444268&action=review

> Source/WebKit/Platform/IPC/Decoder.h:63
>      Decoder(const Decoder&) = delete;
>      Decoder(Decoder&&) = delete;
> +    Decoder& operator=(const Decoder&) = delete;
> +    Decoder& operator=(Decoder&&) = delete;

I understand the elegance of explicitly deleting both the copy and move constructor and assignment operator, but keep in mind that if you delete the copy and don’t define a move you will get a compilation error just you would if it was deleted. So you don’t need to delete the move ones.

> Source/WebKit/Platform/IPC/Encoder.h:52
> +    Encoder(const Encoder&) = delete;
> +    Encoder(Encoder&&) = delete;
> +    Encoder& operator=(const Encoder&) = delete;
> +    Encoder& operator=(Encoder&&) = delete;

Ditto.