Bug 233134 – Remove some dead code from IPC::Encoder / IPC::Decoder

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Remove some dead code from IPC::Encoder / IPC::Decoder.

[Chris Dumez]

Created attachment 444268 [details]
Patch

[EWS]

Committed r285818 (244260@main): <https://commits.webkit.org/244260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444268 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85421330>

[Darin Adler]

Comment on attachment 444268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444268&action=review

> Source/WebKit/Platform/IPC/Decoder.h:63
>      Decoder(const Decoder&) = delete;
>      Decoder(Decoder&&) = delete;
> +    Decoder& operator=(const Decoder&) = delete;
> +    Decoder& operator=(Decoder&&) = delete;

I understand the elegance of explicitly deleting both the copy and move constructor and assignment operator, but keep in mind that if you delete the copy and don’t define a move you will get a compilation error just you would if it was deleted. So you don’t need to delete the move ones.

> Source/WebKit/Platform/IPC/Encoder.h:52
> +    Encoder(const Encoder&) = delete;
> +    Encoder(Encoder&&) = delete;
> +    Encoder& operator=(const Encoder&) = delete;
> +    Encoder& operator=(Encoder&&) = delete;

Ditto.