Bug 233119 - Stack overflow with revert-layer
Summary: Stack overflow with revert-layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
: 233068 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-11-15 00:49 PST by Antti Koivisto
Modified: 2021-11-15 03:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.93 KB, patch)
2021-11-15 01:01 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (6.39 KB, patch)
2021-11-15 01:37 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-11-15 00:49:05 PST 
boom
Comment 1 Antti Koivisto 2021-11-15 00:51:03 PST 
rdar://85342210
Comment 2 Antti Koivisto 2021-11-15 01:01:20 PST 
Created attachment 444219 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-11-15 01:35:04 PST 
Comment on attachment 444219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444219&action=review

> Source/WebCore/style/StyleBuilder.cpp:398
>      if (!rollbackLayerPriority)
> -        return nullptr;
> +        return ensureRollbackCascadeForRevert(cascadeLevel);

There should be tests for this, that revert-layer behaves like revert with no layers.
Comment 4 Antti Koivisto 2021-11-15 01:37:39 PST 
Created attachment 444223 [details]
Patch
Comment 5 Antti Koivisto 2021-11-15 01:38:13 PST 
Comment on attachment 444219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444219&action=review

>> Source/WebCore/style/StyleBuilder.cpp:398
>> +        return ensureRollbackCascadeForRevert(cascadeLevel);
> 
> There should be tests for this, that revert-layer behaves like revert with no layers.

I'll do the change separately.
Comment 6 EWS 2021-11-15 03:12:40 PST 
Committed r285801 (244245@main): <https://commits.webkit.org/244245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444223 [details].
Comment 7 Antti Koivisto 2021-11-15 03:19:59 PST 
*** Bug 233068 has been marked as a duplicate of this bug. ***