Bug 233094 – [libpas] update to 48d608bf31ba92f8059d2c76488f00c52aaca15a: changes to support universal isoheaps

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[Filip Pizlo]

...

[Filip Pizlo]

Created attachment 444161 [details]
the patch

[Yusuke Suzuki]

Comment on attachment 444161 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444161&action=review

r=me

> Source/bmalloc/libpas/README:1
> +# libpas - Phil's Awesome System

NICE

> Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c:535
> +    static const bool verbose = false;

Maybe we do not need `static` here.

[Filip Pizlo]

Seems like the one EWS failure is most likely fallout from Michael's change:

stdout:

stderr:
ASSERTION FAILED: m_regs.regT2 != MacroAssembler::InvalidGPRReg
./yarr/YarrJIT.cpp(4336) : void JSC::Yarr::YarrGenerator<JSC::Yarr::YarrJITRegisters>::compileInline(JSC::Yarr::YarrBoyerMoyerData &) [YarrJITRegs = JSC::Yarr::YarrJITRegisters]
1   0x1081255d9 WTFCrash
2   0x108ae71db WTFCrashWithInfo(int, char const*, char const*, int)
3   0x10a4c052c JSC::Yarr::YarrGenerator<JSC::Yarr::YarrJITRegisters>::compileInline(JSC::Yarr::YarrBoyerMoyerData&)
4   0x10a4c021e JSC::Yarr::jitCompileInlinedTest(WTF::StackCheck*, WTF::String const&, WTF::OptionSet<JSC::Yarr::Flags>, JSC::Yarr::CharSize, JSC::VM const*, JSC::Yarr::YarrBoyerMoyerData&, JSC::MacroAssembler&, JSC::Yarr::YarrJITRegisters&)
5   0x10859f6ae JSC::DFG::SpeculativeJIT::compileRegExpTestInline(JSC::DFG::Node*)::$_9::operator()() const
6   0x10859ed69 JSC::DFG::SpeculativeJIT::compileRegExpTestInline(JSC::DFG::Node*)
7   0x1085a3533 JSC::DFG::SpeculativeJIT::compile(JSC::DFG::Node*)
8   0x10832d40c JSC::DFG::SpeculativeJIT::compileCurrentBlock()
9   0x108346b78 JSC::DFG::SpeculativeJIT::compile()
10  0x10932ee66 JSC::DFG::JITCompiler::compileBody()
11  0x1093326b7 JSC::DFG::JITCompiler::compileFunction()
12  0x1093fd7ee JSC::DFG::Plan::compileInThreadImpl()
13  0x10992ef2c JSC::JITPlan::compileInThread(JSC::JITWorklistThread*)
14  0x1099b3051 JSC::JITWorklistThread::work()
15  0x10813cc63 WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0::operator()() const
16  0x10813c7fe WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call()
17  0x108153b42 WTF::Function<void ()>::operator()() const
18  0x10822e158 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*)
19  0x10823bfb8 WTF::wtfThreadEntryPoint(void*)
20  0x7fff72a30109 _pthread_start
21  0x7fff72a2bb8b thread_start

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/285789/webkit

[Radar WebKit Bug Importer]

<rdar://problem/85391423>