Bug 233092 - [GTK] Implement UIScriptController sendEventStream for wheel events
Summary: [GTK] Implement UIScriptController sendEventStream for wheel events
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-13 14:58 PST by Simon Fraser (smfr)
Modified: 2023-05-29 06:02 PDT (History)
11 users (show)

See Also:

Attachments
Patch (18.74 KB, patch)
2022-01-06 03:03 PST, Chris Lord 		clord: review?
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-11-13 14:58:11 PST 
I'm starting to convert tests that use eventSender.mouseScrollByWithWheelAndMomentumPhases() to UIScriptController.sendEventStream, so it would be good if GTK implemented this.

See http://trac.webkit.org/r285390
Comment 1 Chris Lord 2022-01-06 03:03:44 PST 
Created attachment 448483 [details]
Patch
Comment 2 EWS Watchlist 2022-01-06 03:05:21 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Lord 2022-01-06 03:06:31 PST 
As far as I know there are no tests using sendEventStream that aren't specific to iOS at the moment, so this is basically untested. Attaching the patch so this can be picked up later when there are some tests with which to test it.

It shouldn't take much adaptation to do the equivalent for WPE, it might be good to share the JSON parsing in UIScriptControllerGtk when that happens.
Comment 4 Claudio Saavedra 2023-05-29 06:02:09 PDT 
Skipping imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html?touch in https://github.com/WebKit/WebKit/pull/14452 , as the test crashes due to missing sendEventStream in both GTK and WPE. Would be good to revisit this patch and land.