RESOLVED FIXED233090
Implement UIScriptController.sendEventStream() for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=233090
Summary Implement UIScriptController.sendEventStream() for DumpRenderTree
Simon Fraser (smfr)
Reported 2021-11-13 13:19:25 PST
Implement UIScriptController.sendEventStream() for DumpRenderTree
Attachments
Patch (19.05 KB, patch)
2021-11-13 13:21 PST, Simon Fraser (smfr)
wenson_hsieh: review+
ews-feeder: commit-queue-
Patch (20.83 KB, patch)
2021-11-13 14:27 PST, Simon Fraser (smfr)
simon.fraser: commit-queue+
Simon Fraser (smfr)
Comment 1 2021-11-13 13:21:02 PST
Wenson Hsieh
Comment 2 2021-11-13 13:26:20 PST
Comment on attachment 444147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444147&action=review r=mews > Tools/DumpRenderTree/mac/EventSendingController.mm:888 > + // Note that the delta get convered to integral values here. NSEvent has float deltas, CGEvent has integral deltas. sp. - "convered" > Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:178 > +static NSString* const TopLevelEventInfoKey = @"events"; Nit - * on the wrong side for these constants.
Simon Fraser (smfr)
Comment 3 2021-11-13 14:27:53 PST
EWS
Comment 4 2021-11-13 15:04:13 PST
Committed r285781 (244225@main): <https://commits.webkit.org/244225@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444150 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-13 15:05:20 PST
Note You need to log in before you can comment on or make changes to this bug.