Bug 233090 - Implement UIScriptController.sendEventStream() for DumpRenderTree
Summary: Implement UIScriptController.sendEventStream() for DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-13 13:19 PST by Simon Fraser (smfr)
Modified: 2021-11-13 17:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (19.05 KB, patch)
2021-11-13 13:21 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.83 KB, patch)
2021-11-13 14:27 PST, Simon Fraser (smfr) 		simon.fraser: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-11-13 13:19:25 PST 
Implement UIScriptController.sendEventStream() for DumpRenderTree
Comment 1 Simon Fraser (smfr) 2021-11-13 13:21:02 PST 
Created attachment 444147 [details]
Patch
Comment 2 Wenson Hsieh 2021-11-13 13:26:20 PST 
Comment on attachment 444147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444147&action=review

r=mews

> Tools/DumpRenderTree/mac/EventSendingController.mm:888
> +    // Note that the delta get convered to integral values here. NSEvent has float deltas, CGEvent has integral deltas.

sp. - "convered"

> Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:178
> +static NSString* const TopLevelEventInfoKey = @"events";

Nit - * on the wrong side for these constants.
Comment 3 Simon Fraser (smfr) 2021-11-13 14:27:53 PST 
Created attachment 444150 [details]
Patch
Comment 4 EWS 2021-11-13 15:04:13 PST 
Committed r285781 (244225@main): <https://commits.webkit.org/244225@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444150 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-13 15:05:20 PST 
<rdar://problem/85379929>