Bug 23309 – Chromium crashes with custom cursors

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Ananta Iyengar]

This is a chromium only issue.
. Navigate Google maps
2. Scroll in/out, drag, move the mouse cursor in/out of the map area to 
change the custom cursor until problem appears
3. See Chromium Crash
4. Sigh :(

This is a bug in the ImageSource::clear implementation in ImageSourceSkia.cpp.

I will be submitting a patch shortly.

[Ananta Iyengar]

Created attachment 26699 [details]
Contains the fix for the custom cursor crash with Chromium

[Ananta Iyengar]

Comment on attachment 26699 [details]
Contains the fix for the custom cursor crash with Chromium

There are some unrelated changes in this patch. Will upload a new one shortly

[Ananta Iyengar]

Created attachment 26700 [details]
Fix for the cursor crash with Chromium

[Eric Seidel (no email)]

Comment on attachment 26700 [details]
Fix for the cursor crash with Chromium

The ChangeList wrong.  You you set EMAIL_ADDRESS in your local environment so future runs of prepare-ChangeLog know what your email address is ([e-mail]).  Your REAL_NAME value should also be set to something other than "iyengar" (currently it's falling back onto your username).  I would revert your local ChangeLog and run prepare-ChangeLog again (once and only once).

You seem to have corrected setData to 8 spaces of indent from 6 spaces on all platforms except chromium. :)

[Ananta Iyengar]

Created attachment 26702 [details]
Fix for the custom cursor crash with Chromium. Updated based on code review comments by Eric

[Ananta Iyengar]

I have uploaded a new patch which addresses these comments. Please take another look.

-Ananta

(In reply to comment #4)
> (From update of attachment 26700 [details] [review])
> The ChangeList wrong.  You you set EMAIL_ADDRESS in your local environment so
> future runs of prepare-ChangeLog know what your email address is
> ([e-mail]).  Your REAL_NAME value should also be set to something
> other than "iyengar" (currently it's falling back onto your username).  I would
> revert your local ChangeLog and run prepare-ChangeLog again (once and only
> once).
> 
> You seem to have corrected setData to 8 spaces of indent from 6 spaces on all
> platforms except chromium. :)
> 

[Ananta Iyengar]

Comment on attachment 26702 [details]
Fix for the custom cursor crash with Chromium. Updated based on code review comments by Eric

I had added comments by mistake to the diff directly. Will upload a new patch

[Ananta Iyengar]

Created attachment 26800 [details]
Updated patch created off the changelog this time.

[Holger Freyther]

separate the style changes from the actual fix?

[Eric Seidel (no email)]

Comment on attachment 26800 [details]
Updated patch created off the changelog this time.

ChangeLog needs to be fix to Ananta's full name when landing.  There is also a Tab in the changelog.  Otherwise this looks fine.

[Ananta Iyengar]

Comment on attachment 26800 [details]
Updated patch created off the changelog this time.

Will update a new patch based on the comments by Eric.

[Ananta Iyengar]

Created attachment 27369 [details]
Updated patch with the reviewer name fixed and tab removed.

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/40722.

[Dimitri Glazkov (Google)]

Comment on attachment 27369 [details]
Updated patch with the reviewer name fixed and tab removed.

Clearing review flag to remove from queue.