Bug 233072 - ::backdrop pseudo element should react to event listeners
Summary: ::backdrop pseudo element should react to event listeners
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
Keywords: InRadar
Depends on:
Blocks: dialog-element
  Show dependency treegraph
Reported: 2021-11-12 14:01 PST by Tim Nguyen (:ntim)
Modified: 2022-01-11 07:19 PST (History)
8 users (show)

See Also:

Patch (4.53 KB, patch)
2022-01-10 12:53 PST, Tim Nguyen (:ntim)
zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.46 KB, patch)
2022-01-11 06:34 PST, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-11-12 14:01:16 PST
<dialog id=dialog onclick="alert('clicked')">hello</dialog>


the onclick does not work on the ::backdrop, it does in Firefox/Chrome.
Comment 1 Radar WebKit Bug Importer 2021-11-12 15:27:22 PST
Comment 3 Tim Nguyen (:ntim) 2022-01-10 12:53:06 PST
Created attachment 448789 [details]
Comment 4 zalan 2022-01-10 17:31:37 PST
Comment on attachment 448789 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=448789&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:201
> -    // Update or attach to renderer parent
> +    // Update or attach to renderer
>      WeakPtr currentParent = backdropRenderer->parent();
> -    WeakPtr newParent = renderer.parent();
> +    WeakPtr newParent = renderer;

auto backdropRenderer = renderer.backdropRenderer();

don't we always end up either with no backdropRenderer or with one with the correct parent (renderer)? I didn't look through all the cases but could you explain the re-parenting case? (if no reparenting ever happens, we could make this function a lot simpler)
Comment 5 Tim Nguyen (:ntim) 2022-01-11 06:34:44 PST
Created attachment 448843 [details]
Comment 6 EWS 2022-01-11 07:19:36 PST
Committed r287878 (245922@main): <https://commits.webkit.org/245922@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448843 [details].