Bug 233058 - [JSC] update test262
Summary: [JSC] update test262
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-12 12:11 PST by Joseph Griego
Modified: 2021-11-12 16:09 PST (History)
6 users (show)

See Also:

Attachments
Patch (314.34 KB, patch)
2021-11-12 12:23 PST, Joseph Griego 		no flags Details | Formatted Diff | Diff
Patch (307.73 KB, patch)
2021-11-12 14:55 PST, Joseph Griego 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Griego 2021-11-12 12:11:42 PST 
[JSC] update test262
Comment 1 Joseph Griego 2021-11-12 12:23:56 PST 
Created attachment 444088 [details]
Patch
Comment 2 Yusuke Suzuki 2021-11-12 12:24:51 PST 
Did you run it on macOS Monterey? Currently our bot is based on that machine.
Comment 3 Joseph Griego 2021-11-12 12:27:23 PST 
Hi! First time sending a patch--trying to pick up some changes for the ShadowRealm tests.

ysuzuki: i don't have access to a macos machine--i figured I would wait for CI and verify the expectation file based on that?
Comment 4 Joseph Griego 2021-11-12 13:03:49 PST 
I see, apologies. It looks like the bot in question runs only after landing? I'll see what I can do to run on the right platform, or close this. (Or whatever else you advise)
Comment 5 Yusuke Suzuki 2021-11-12 13:05:36 PST 
(In reply to Joseph Griego from comment #4)
> I see, apologies. It looks like the bot in question runs only after landing?
> I'll see what I can do to run on the right platform, or close this. (Or
> whatever else you advise)

OK, so can you monitor the bot after landing and fix the bot after failures are listed?
Comment 6 Yusuke Suzuki 2021-11-12 13:05:56 PST 
(In reply to Yusuke Suzuki from comment #5)
> (In reply to Joseph Griego from comment #4)
> > I see, apologies. It looks like the bot in question runs only after landing?
> > I'll see what I can do to run on the right platform, or close this. (Or
> > whatever else you advise)
> 
> OK, so can you monitor the bot after landing and fix the bot after failures
> are listed?

Please land it when you can monitor the bot :)
Comment 7 Joseph Griego 2021-11-12 14:55:45 PST 
Created attachment 444112 [details]
Patch
Comment 8 Joseph Griego 2021-11-12 14:57:39 PST 
patch fixed for the right version of macos, thank you rkirsling ':)
Comment 9 EWS 2021-11-12 16:08:12 PST 
Committed r285760 (244209@main): <https://commits.webkit.org/244209@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444112 [details].
Comment 10 Radar WebKit Bug Importer 2021-11-12 16:09:23 PST 
<rdar://problem/85361163>