.
Created attachment 444073 [details] Depends on #233010
Created attachment 444194 [details] Minor adjustments / rebase on trunk
Comment on attachment 444194 [details] Minor adjustments / rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=444194&action=review r=me > Source/WebCore/dom/ImageOverlay.cpp:501 > + for (size_t index = 0; index < result.blocks.size(); ++index) { Should we add an assertion that `result.blocks.size() == elements.blocks.size()`? > Source/WebCore/dom/ImageOverlay.cpp:502 > + auto blockContainer = elements.blocks[index]; Nit: I would move this declaration after the `continue`, since it's not used otherwise.
Comment on attachment 444194 [details] Minor adjustments / rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=444194&action=review Thanks for the review! >> Source/WebCore/dom/ImageOverlay.cpp:501 >> + for (size_t index = 0; index < result.blocks.size(); ++index) { > > Should we add an assertion that `result.blocks.size() == elements.blocks.size()`? Yes, added! >> Source/WebCore/dom/ImageOverlay.cpp:502 >> + auto blockContainer = elements.blocks[index]; > > Nit: I would move this declaration after the `continue`, since it's not used otherwise. Good catch — moved to after the continue.
Created attachment 444386 [details] Patch for landing
Committed r285862 (244288@main): <https://commits.webkit.org/244288@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444386 [details].
<rdar://problem/85459672>