Bug 233023 - Implement custom element definition's *disable shadow* flag
Summary: Implement custom element definition's *disable shadow* flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Minor
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks: 197960
  Show dependency tree / graph
 
Reported: 2021-11-11 16:28 PST by Alexey Shvayka
Modified: 2021-11-12 14:12 PST (History)
9 users (show)

See Also:

Attachments
Patch (18.53 KB, patch)
2021-11-11 16:32 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (18.75 KB, patch)
2021-11-11 19:45 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-11-11 16:28:35 PST 
Implement custom element definition's *disable shadow* flag
Comment 1 Alexey Shvayka 2021-11-11 16:32:16 PST 
Created attachment 444022 [details]
Patch
Comment 2 Alexey Shvayka 2021-11-11 19:45:50 PST 
Created attachment 444037 [details]
Patch

Include HashSet.h
Comment 3 Geoffrey Garen 2021-11-12 09:59:48 PST 
Comment on attachment 444037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444037&action=review

r=me

> Source/WebCore/bindings/js/JSCustomElementInterface.cpp:53
> +    , m_isShadowDisabled(false)

I have a style preference for boolean conditions to be named in the affirmative, to avoid double negatives. So I would call this "isShadowEnabled", and initialize to true. But I guess the is the spec API name, so I'll ignore my preference here.

> Source/WebCore/bindings/js/JSCustomElementInterface.h:111
> +    bool m_isShadowDisabled : 1;

Usually we don't do : 1 until there are more booleans to pack; but you mentioned that the follow-up patch will add them, so this is OK to me.
Comment 4 Alexey Shvayka 2021-11-12 13:54:18 PST 
Comment on attachment 444037 [details]
Patch

Thank you for live review Geoff!

Landing since EWS failures are unrelated.
Comment 5 EWS 2021-11-12 14:11:20 PST 
Committed r285740 (244199@main): <https://commits.webkit.org/244199@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444037 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-12 14:12:29 PST 
<rdar://problem/85357120>