Bug 233023 – Implement custom element definition's *disable shadow* flag

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Shvayka]

Implement custom element definition's *disable shadow* flag

[Alexey Shvayka]

Created attachment 444022 [details]
Patch

[Alexey Shvayka]

Created attachment 444037 [details]
Patch

Include HashSet.h

[Geoffrey Garen]

Comment on attachment 444037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444037&action=review

r=me

> Source/WebCore/bindings/js/JSCustomElementInterface.cpp:53
> +    , m_isShadowDisabled(false)

I have a style preference for boolean conditions to be named in the affirmative, to avoid double negatives. So I would call this "isShadowEnabled", and initialize to true. But I guess the is the spec API name, so I'll ignore my preference here.

> Source/WebCore/bindings/js/JSCustomElementInterface.h:111
> +    bool m_isShadowDisabled : 1;

Usually we don't do : 1 until there are more booleans to pack; but you mentioned that the follow-up patch will add them, so this is OK to me.

[Alexey Shvayka]

Comment on attachment 444037 [details]
Patch

Thank you for live review Geoff!

Landing since EWS failures are unrelated.

[EWS]

Committed r285740 (244199@main): <https://commits.webkit.org/244199@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444037 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85357120>