Bug 233019 - Add VM::writeBarrier() and VM::mutatorFence().
Summary: Add VM::writeBarrier() and VM::mutatorFence().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 232849
  Show dependency tree / graph
 
Reported: 2021-11-11 15:26 PST by Mark Lam
Modified: 2021-11-11 15:59 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (53.53 KB, patch)
2021-11-11 15:33 PST, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-11-11 15:26:09 PST 
These are ALWAYS_INLINE functions that will forward the call to the Heap versions.  Adding these allows us to make all the client code more terse, and also makes it easier to redirect the underlying writeBarrier implementation later for global GC work.  Additionally, this will help make the global GC patch less of a mega patch and easier to review later.

Also remove unused Heap::writeBarrierWithoutFence().
Comment 1 Radar WebKit Bug Importer 2021-11-11 15:27:17 PST 
<rdar://problem/85318693>
Comment 2 Mark Lam 2021-11-11 15:33:32 PST 
Created attachment 444011 [details]
proposed patch.
Comment 3 Mark Lam 2021-11-11 15:59:14 PST 
Thanks for the review.  Landed in r285687: <http://trac.webkit.org/r285687>.