Bug 233016 - REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
Summary: REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 232737
  Show dependency treegraph
 
Reported: 2021-11-11 14:21 PST by Truitt Savell
Modified: 2021-11-11 15:08 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.67 KB, patch)
2021-11-11 14:39 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2021-11-11 14:21:29 PST
26 API failures started between r285591 - r285609

these are all related to InAppBrowserPrivacy. 

build: https://build.webkit.org/#/builders/267/builds/498

stdio: https://build.webkit.org/#/builders/267/builds/498/steps/17/logs/stdio
Comment 1 Radar WebKit Bug Importer 2021-11-11 14:21:53 PST
<rdar://problem/85315536>
Comment 2 Truitt Savell 2021-11-11 14:23:47 PST
It looks like https://trac.webkit.org/changeset/285594/webkit could have possibly caused this.
Comment 3 Chris Dumez 2021-11-11 14:24:59 PST
(In reply to Truitt Savell from comment #2)
> It looks like https://trac.webkit.org/changeset/285594/webkit could have
> possibly caused this.

Oh? I can look but it seems a little surprising given that captive portal mode is disabled by default.
Comment 4 Ryan Haddad 2021-11-11 14:32:19 PST
(In reply to Chris Dumez from comment #3)
> (In reply to Truitt Savell from comment #2)
> > It looks like https://trac.webkit.org/changeset/285594/webkit could have
> > possibly caused this.
> 
> Oh? I can look but it seems a little surprising given that captive portal
> mode is disabled by default.
We noticed that ios-api EWS showed these as "new" failures on https://bugs.webkit.org/show_bug.cgi?id=232737, we're still confirming though.
Comment 5 Chris Dumez 2021-11-11 14:39:12 PST
Created attachment 444006 [details]
Patch
Comment 6 Brent Fulgham 2021-11-11 14:40:51 PST
Comment on attachment 444006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444006&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7629
> +// Also, some API tests rely on the browser entitlement not being present.

We may have a way to address this, but should do so in a follow-up patch.
Comment 7 Chris Dumez 2021-11-11 15:08:32 PST
Comment on attachment 444006 [details]
Patch

Clearing flags on attachment: 444006

Committed r285672 (244159@main): <https://commits.webkit.org/244159@main>
Comment 8 Chris Dumez 2021-11-11 15:08:35 PST
All reviewed patches have been landed.  Closing bug.