Bug 233016 – REGRESSION: 26 InAppBrowserPrivacy API failures on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Truitt Savell]

26 API failures started between r285591 - r285609

these are all related to InAppBrowserPrivacy. 

build: https://build.webkit.org/#/builders/267/builds/498

stdio: https://build.webkit.org/#/builders/267/builds/498/steps/17/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/85315536>

[Truitt Savell]

It looks like https://trac.webkit.org/changeset/285594/webkit could have possibly caused this.

[Chris Dumez]

(In reply to Truitt Savell from comment #2)
> It looks like https://trac.webkit.org/changeset/285594/webkit could have
> possibly caused this.

Oh? I can look but it seems a little surprising given that captive portal mode is disabled by default.

[Ryan Haddad]

(In reply to Chris Dumez from comment #3)
> (In reply to Truitt Savell from comment #2)
> > It looks like https://trac.webkit.org/changeset/285594/webkit could have
> > possibly caused this.
> 
> Oh? I can look but it seems a little surprising given that captive portal
> mode is disabled by default.
We noticed that ios-api EWS showed these as "new" failures on https://bugs.webkit.org/show_bug.cgi?id=232737, we're still confirming though.

[Chris Dumez]

Created attachment 444006 [details]
Patch

[Brent Fulgham]

Comment on attachment 444006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444006&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7629
> +// Also, some API tests rely on the browser entitlement not being present.

We may have a way to address this, but should do so in a follow-up patch.

[Chris Dumez]

Comment on attachment 444006 [details]
Patch

Clearing flags on attachment: 444006

Committed r285672 (244159@main): <https://commits.webkit.org/244159@main>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.