Bug 233013 - Disable MathML when in Captive Portal Mode
Summary: Disable MathML when in Captive Portal Mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-11 14:04 PST by Chris Dumez
Modified: 2021-11-12 10:29 PST (History)
13 users (show)

See Also:

Attachments
Patch (8.19 KB, patch)
2021-11-11 14:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2021-11-12 07:23 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.81 KB, patch)
2021-11-12 07:51 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.82 KB, patch)
2021-11-12 08:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-11 14:04:31 PST 
Disable MathML when in Captive Portal Mode.
Comment 1 Chris Dumez 2021-11-11 14:04:48 PST 
<rdar://84567129>
Comment 2 Chris Dumez 2021-11-11 14:26:34 PST 
Created attachment 444002 [details]
Patch
Comment 3 Brent Fulgham 2021-11-11 16:33:28 PST 
Comment on attachment 444002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444002&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Add experimental feature flag for MathML and update implementation in WebCore to only support

Nit: It's not really an experimental feature flag -- it's a runtime feature flag.
Comment 4 Chris Dumez 2021-11-11 16:34:00 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 444002 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444002&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:9
> > +        Add experimental feature flag for MathML and update implementation in WebCore to only support
> 
> Nit: It's not really an experimental feature flag -- it's a runtime feature
> flag.

Indeed, force of habit. Will fix before landing.
Comment 5 Chris Dumez 2021-11-12 07:23:29 PST 
Created attachment 444065 [details]
Patch
Comment 6 Chris Dumez 2021-11-12 07:51:47 PST 
Created attachment 444068 [details]
Patch
Comment 7 EWS 2021-11-12 08:35:38 PST 
Brent Fulham found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 8 Brent Fulgham 2021-11-12 08:36:45 PST 
(In reply to EWS from comment #7)
> Brent Fulham found in

:-|
Comment 9 Chris Dumez 2021-11-12 08:37:43 PST 
Created attachment 444071 [details]
Patch
Comment 10 Chris Dumez 2021-11-12 08:38:34 PST 
(In reply to Brent Fulgham from comment #8)
> (In reply to EWS from comment #7)
> > Brent Fulham found in
> 
> :-|

Sorry I am a soccer fan :P
Comment 11 EWS 2021-11-12 10:29:21 PST 
Committed r285731 (244190@main): <https://commits.webkit.org/244190@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444071 [details].