Bug 233013 – Disable MathML when in Captive Portal Mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Disable MathML when in Captive Portal Mode.

[Chris Dumez]

<rdar://84567129>

[Chris Dumez]

Created attachment 444002 [details]
Patch

[Brent Fulgham]

Comment on attachment 444002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444002&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Add experimental feature flag for MathML and update implementation in WebCore to only support

Nit: It's not really an experimental feature flag -- it's a runtime feature flag.

[Chris Dumez]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 444002 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444002&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:9
> > +        Add experimental feature flag for MathML and update implementation in WebCore to only support
> 
> Nit: It's not really an experimental feature flag -- it's a runtime feature
> flag.

Indeed, force of habit. Will fix before landing.

[Chris Dumez]

Created attachment 444065 [details]
Patch

[Chris Dumez]

Created attachment 444068 [details]
Patch

[EWS]

Brent Fulham found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Brent Fulgham]

(In reply to EWS from comment #7)
> Brent Fulham found in

:-|

[Chris Dumez]

Created attachment 444071 [details]
Patch

[Chris Dumez]

(In reply to Brent Fulgham from comment #8)
> (In reply to EWS from comment #7)
> > Brent Fulham found in
> 
> :-|

Sorry I am a soccer fan :P

[EWS]

Committed r285731 (244190@main): <https://commits.webkit.org/244190@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444071 [details].