Bug 233002 - [LFC][IFC] Reset InlineTextItem width on bidi split
Summary: [LFC][IFC] Reset InlineTextItem width on bidi split
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-11 10:00 PST by zalan
Modified: 2021-11-11 11:08 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.47 KB, patch)
2021-11-11 10:03 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-11-11 10:00:30 PST
ssia
Comment 1 zalan 2021-11-11 10:03:27 PST
Created attachment 443963 [details]
Patch
Comment 2 Darin Adler 2021-11-11 10:05:43 PST
Comment on attachment 443963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443963&action=review

> Source/WebCore/ChangeLog:8
> +        We remeasure the individual inline items right before line breaking.

Was there a test that could have caught this mistake?
Comment 3 zalan 2021-11-11 10:14:17 PST
(In reply to Darin Adler from comment #2)
> Comment on attachment 443963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443963&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        We remeasure the individual inline items right before line breaking.
> 
> Was there a test that could have caught this mistake?
fast/text/international/bidi-layout-across-linebreak.html would have caught this, if this codepath was enabled (which it did at my trybot bug 229638).  
I am in the middle of enabling bidi content (including this codepath) for IFC (bug 232980) and going through the failures at https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Release-WK1-Tests-EWS/r443898-20106/results.html (the trybot output)
Comment 4 EWS 2021-11-11 11:07:03 PST
Committed r285642 (244143@main): <https://commits.webkit.org/244143@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443963 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-11 11:08:52 PST
<rdar://problem/85307114>