RESOLVED FIXED 233002
[LFC][IFC] Reset InlineTextItem width on bidi split 
https://bugs.webkit.org/show_bug.cgi?id=233002
Summary [LFC][IFC] Reset InlineTextItem width on bidi split
zalan
Reported 2021-11-11 10:00:30 PST
ssia
Attachments
Patch (1.47 KB, patch)
2021-11-11 10:03 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-11-11 10:03:27 PST
Created attachment 443963 [details] Patch
Darin Adler
Comment 2 2021-11-11 10:05:43 PST
Comment on attachment 443963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443963&action=review > Source/WebCore/ChangeLog:8 > + We remeasure the individual inline items right before line breaking. Was there a test that could have caught this mistake?
zalan
Comment 3 2021-11-11 10:14:17 PST
(In reply to Darin Adler from comment #2) > Comment on attachment 443963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443963&action=review > > > Source/WebCore/ChangeLog:8 > > + We remeasure the individual inline items right before line breaking. > > Was there a test that could have caught this mistake? fast/text/international/bidi-layout-across-linebreak.html would have caught this, if this codepath was enabled (which it did at my trybot bug 229638). I am in the middle of enabling bidi content (including this codepath) for IFC (bug 232980) and going through the failures at https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Release-WK1-Tests-EWS/r443898-20106/results.html (the trybot output)
EWS
Comment 4 2021-11-11 11:07:03 PST
Committed r285642 (244143@main): <https://commits.webkit.org/244143@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443963 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-11 11:08:52 PST
<rdar://problem/85307114>
Note You need to log in before you can comment on or make changes to this bug.