Bug 232999 – Fix for thread deadlocks during layout tests in isolated tree mode.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Isolated tree mode: Fix for WTR::AccessibilityUIElement calls into the AX API on the AX thread that must hit the main thread.

[Radar WebKit Bug Importer]

<rdar://problem/85300861>

[Andres Gonzalez]

Created attachment 443954 [details]
Patch

[Andres Gonzalez]

Created attachment 443957 [details]
Patch

[chris fleizach]

Comment on attachment 443957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443957&action=review

> Tools/ChangeLog:10
> +        dispatched to a secndary, mocked thread created by the

secondary

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:116
> +        spinMainRunLoop();

we'll need to keep spending the run loop while we wait. 
this also means we don't need this semaphore. we could put a bool in AXThread::dispatch that marks complete and then do a 

while ( !complete ) {
  spinMainRunLoop();
}

[Andres Gonzalez]

Created attachment 443988 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #4)
> Comment on attachment 443957 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443957&action=review
> 
> > Tools/ChangeLog:10
> > +        dispatched to a secndary, mocked thread created by the
> 
> secondary

Fixed.
> 
> > Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:116
> > +        spinMainRunLoop();
> 
> we'll need to keep spending the run loop while we wait. 
> this also means we don't need this semaphore. we could put a bool in
> AXThread::dispatch that marks complete and then do a 
> 
> while ( !complete ) {
>   spinMainRunLoop();
> }

Thanks! so much simpler and works.

[EWS]

Committed r285671 (244158@main): <https://commits.webkit.org/244158@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443988 [details].