Bug 232998 – Non-unified build fixes, early November 2021 edition, bis

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

👺️

[Adrian Perez]

Created attachment 443951 [details]
Patch

[EWS]

Committed r285654 (244152@main): <https://commits.webkit.org/244152@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443951 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85313167>

[Darin Adler]

Comment on attachment 443951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443951&action=review

> Source/WebCore/ChangeLog:35
> +        * platform/gamepad/GamepadConstants.h: Add missing WTF:: namespace prefix to uses of
> +        WTF::String.

This was an incorrect change. Could you tell me more about why the compile failed without it?

> Source/WebCore/platform/gamepad/GamepadConstants.h:67
> -const String& standardGamepadMappingString();
> +const WTF::String& standardGamepadMappingString();
>  #if ENABLE(WEBXR)
> -const String& xrStandardGamepadMappingString();
> +const WTF::String& xrStandardGamepadMappingString();
>  #endif

This is not the correct idiom. Instead this header should include <wtf/Forward.h> and remove the declaration of the String class above.

[Adrian Perez]

(In reply to Darin Adler from comment #4)
> Comment on attachment 443951 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443951&action=review
> 
> > Source/WebCore/ChangeLog:35
> > +        * platform/gamepad/GamepadConstants.h: Add missing WTF:: namespace prefix to uses of
> > +        WTF::String.
> 
> This was an incorrect change. Could you tell me more about why the compile
> failed without it?
> 
> > Source/WebCore/platform/gamepad/GamepadConstants.h:67
> > -const String& standardGamepadMappingString();
> > +const WTF::String& standardGamepadMappingString();
> >  #if ENABLE(WEBXR)
> > -const String& xrStandardGamepadMappingString();
> > +const WTF::String& xrStandardGamepadMappingString();
> >  #endif
> 
> This is not the correct idiom. Instead this header should include
> <wtf/Forward.h> and remove the declaration of the String class above.

Fixed in r285715 — thanks for commenting on this :)