Bug 232983 - AX: Implement AXCoreObject::value for AXIsolatedObject
Summary: AX: Implement AXCoreObject::value for AXIsolatedObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-10 21:04 PST by Tyler Wilcock
Modified: 2021-11-11 07:57 PST (History)
10 users (show)

See Also:

Attachments
Patch (8.07 KB, patch)
2021-11-10 21:17 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (8.06 KB, patch)
2021-11-10 21:52 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (8.25 KB, patch)
2021-11-10 22:50 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-11-10 21:04:59 PST 
The current implementation returns nothing.

AXIsolatedObject.h
AXValue value() override { return { }; }
Comment 1 Radar WebKit Bug Importer 2021-11-10 21:05:15 PST 
<rdar://problem/85283345>
Comment 2 Tyler Wilcock 2021-11-10 21:17:12 PST 
Created attachment 443904 [details]
Patch
Comment 3 chris fleizach 2021-11-10 21:29:46 PST 
Comment on attachment 443904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443904&action=review

> Source/WebCore/accessibility/AccessibilityObjectInterface.h:1146
> +    virtual AXValue value()

does this still need to be virtual now?
Comment 4 Tyler Wilcock 2021-11-10 21:52:15 PST 
Created attachment 443908 [details]
Patch
Comment 5 chris fleizach 2021-11-10 22:19:12 PST 
Comment on attachment 443908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443908&action=review

> Source/WebCore/accessibility/AccessibilityObjectInterface.h:1146
> +    AXValue value()

it looks like when we have code to inline, the preference is to put it a little farther down the file near things like

inline void AXCoreObject::detachWrapper(AccessibilityDetachmentType detachmentType)
{
Comment 6 Tyler Wilcock 2021-11-10 22:50:11 PST 
Created attachment 443912 [details]
Patch
Comment 7 EWS 2021-11-11 07:57:21 PST 
Committed r285632 (244133@main): <https://commits.webkit.org/244133@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443912 [details].