For future functionality, we need to not crash when a null style is passed to this function. The only place it is used is in EMS and EXS computations. In this case, we will return !ok and not crash.
Created attachment 26677 [details] Patch
Comment on attachment 26677 [details] Patch > + if (!style && (type == CSSPrimitiveValue::CSS_EMS || type == CSSPrimitiveValue::CSS_EXS)) { > + if (ok) > + *ok = false; > + } > + else if (type > CSSPrimitiveValue::CSS_PERCENTAGE && type < CSSPrimitiveValue::CSS_DEG) Brace goes on same line as else in the WebKit coding style. r=me
I will make that change when I checkin
Sending WebCore/ChangeLog Sending WebCore/css/CSSStyleSelector.cpp Transmitting file data .. Committed revision 39878.