RESOLVED FIXED 232965
[WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation 
https://bugs.webkit.org/show_bug.cgi?id=232965
Summary [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's...
pascoe@apple.com
Reported 2021-11-10 13:35:28 PST
Whenever generating assertions via ASC ui, the client data json returned is not the same client data json that is used for hashing purposes. This change modifies the clientDataJson SPI to use the same method as AuthenticatorCoordinator.
Attachments
Patch (14.02 KB, patch)
2021-11-10 14:06 PST, pascoe@apple.com 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.26 KB, patch)
2021-11-10 15:05 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch (14.27 KB, patch)
2021-11-10 15:06 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-10 13:35:45 PST
<rdar://problem/85268216>
Radar WebKit Bug Importer
Comment 2 2021-11-10 13:36:59 PST
<rdar://problem/85268259>
pascoe@apple.com
Comment 3 2021-11-10 14:06:31 PST
Created attachment 443862 [details] Patch
pascoe@apple.com
Comment 4 2021-11-10 14:13:49 PST
In the longer term, we should find a way to avoid generating ClientDataJson in two places.
pascoe@apple.com
Comment 5 2021-11-10 15:05:04 PST
Created attachment 443870 [details] Patch
pascoe@apple.com
Comment 6 2021-11-10 15:06:42 PST
Created attachment 443871 [details] Patch
Brent Fulgham
Comment 7 2021-11-10 15:24:31 PST
Comment on attachment 443871 [details] Patch Looks good! r=me
EWS
Comment 8 2021-11-10 18:52:08 PST
Committed r285617 (244118@main): <https://commits.webkit.org/244118@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443871 [details].
Note You need to log in before you can comment on or make changes to this bug.