Bug 232965 - [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation
Summary: [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-10 13:35 PST by pascoe@apple.com
Modified: 2021-11-10 18:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.02 KB, patch)
2021-11-10 14:06 PST, pascoe@apple.com 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.26 KB, patch)
2021-11-10 15:05 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Patch (14.27 KB, patch)
2021-11-10 15:06 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pascoe@apple.com 2021-11-10 13:35:28 PST 
Whenever generating assertions via ASC ui, the client data json returned is not the same client data json that is used for hashing purposes. This change modifies the clientDataJson SPI to use the same method as AuthenticatorCoordinator.
Comment 1 Radar WebKit Bug Importer 2021-11-10 13:35:45 PST 
<rdar://problem/85268216>
Comment 2 Radar WebKit Bug Importer 2021-11-10 13:36:59 PST 
<rdar://problem/85268259>
Comment 3 pascoe@apple.com 2021-11-10 14:06:31 PST 
Created attachment 443862 [details]
Patch
Comment 4 pascoe@apple.com 2021-11-10 14:13:49 PST 
In the longer term, we should find a way to avoid generating ClientDataJson in two places.
Comment 5 pascoe@apple.com 2021-11-10 15:05:04 PST 
Created attachment 443870 [details]
Patch
Comment 6 pascoe@apple.com 2021-11-10 15:06:42 PST 
Created attachment 443871 [details]
Patch
Comment 7 Brent Fulgham 2021-11-10 15:24:31 PST 
Comment on attachment 443871 [details]
Patch

Looks good! r=me
Comment 8 EWS 2021-11-10 18:52:08 PST 
Committed r285617 (244118@main): <https://commits.webkit.org/244118@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443871 [details].