Bug 232961 - WKSystemPreviewView should be called WKUSDPreviewView
Summary: WKSystemPreviewView should be called WKUSDPreviewView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-10 12:19 PST by Dean Jackson
Modified: 2021-11-11 09:22 PST (History)
2 users (show)

See Also:

Attachments
Patch (32.34 KB, patch)
2021-11-10 12:28 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (32.34 KB, patch)
2021-11-10 12:56 PST, Dean Jackson 		sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS test (32.71 KB, patch)
2021-11-11 08:26 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-11-10 12:19:52 PST 
WKSystemPreviewView is a uninformative name. WKUSDPreviewView is more accurate.

While here, change the WebCore code that looks for SystemPreview MIME types to reflect it is looking for USD.
Comment 1 Radar WebKit Bug Importer 2021-11-10 12:20:19 PST 
<rdar://problem/85265415>
Comment 2 Dean Jackson 2021-11-10 12:28:19 PST 
Created attachment 443847 [details]
Patch
Comment 3 Dean Jackson 2021-11-10 12:56:24 PST 
Created attachment 443855 [details]
Patch
Comment 4 Sam Weinig 2021-11-10 15:01:51 PST 
Comment on attachment 443855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review

r=me, but please make sure it builds.

> Source/WebKit/SourcesCocoa.txt:509
> +UIProcess/ios/WKUSDPreviewView.mm

This needs to be sorted.

> Source/WebKit/UIProcess/SystemPreviewController.cpp:41
>  bool SystemPreviewController::canPreview(const String& mimeType) const

Should this class get renamed in the future as well?
Comment 5 Dean Jackson 2021-11-11 08:25:06 PST 
Comment on attachment 443855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review

>> Source/WebKit/SourcesCocoa.txt:509
>> +UIProcess/ios/WKUSDPreviewView.mm
> 
> This needs to be sorted.

Nice catch.

>> Source/WebKit/UIProcess/SystemPreviewController.cpp:41
>>  bool SystemPreviewController::canPreview(const String& mimeType) const
> 
> Should this class get renamed in the future as well?

Yes, that's coming soon.
Comment 6 Dean Jackson 2021-11-11 08:26:58 PST 
Created attachment 443949 [details]
EWS test
Comment 7 EWS 2021-11-11 09:22:35 PST 
Committed r285635 (244136@main): <https://commits.webkit.org/244136@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443949 [details].