Bug 23294 - add Android platform-specific files to WebCore/editing
Summary: add Android platform-specific files to WebCore/editing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Feng Qian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-13 09:35 PST by Feng Qian
Modified: 2009-02-04 23:28 PST (History)
0 users

See Also:

Attachments
patch v1 (2.69 KB, patch)
2009-01-13 09:45 PST, Feng Qian 		no flags Details | Formatted Diff | Diff
patch v2 (5.15 KB, patch)
2009-01-13 17:29 PST, Feng Qian 		no flags Details | Formatted Diff | Diff
patch v3 (2.50 KB, patch)
2009-01-13 17:30 PST, Feng Qian 		no flags Details | Formatted Diff | Diff
patch v4 (2.50 KB, patch)
2009-01-13 17:33 PST, Feng Qian 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Feng Qian 2009-01-13 09:35:49 PST 
Part of upstreaming Android port. Files do not confirm to WebKit standard yet, create this bug as a placeholder, and ask for code review when files are ready.
Comment 1 Feng Qian 2009-01-13 09:45:01 PST 
Created attachment 26670 [details]
patch v1
Comment 2 Feng Qian 2009-01-13 16:31:35 PST 
Comment on attachment 26670 [details]
patch v1

mrowe, do you mind take a look at this file?
Comment 3 Darin Adler 2009-01-13 16:59:53 PST 
Comment on attachment 26670 [details]
patch v1

> +#include "ClipboardAndroid.h"
> +#include "Document.h"
> +#include "Element.h"
> +#include "htmlediting.h"
> +#include "NotImplemented.h"
> +#include "TextIterator.h"
> +#include "visible_units.h"

I don't think we need any of these includes except for ClipboardAndroid.h.

r=me
Comment 4 Feng Qian 2009-01-13 17:29:15 PST 
Created attachment 26696 [details]
patch v2

Removed unneeded header file includes. Thanks for quick review!
Comment 5 Feng Qian 2009-01-13 17:30:50 PST 
Created attachment 26697 [details]
patch v3

v3, sorry, v2 includes changes of another bug by accident.
Comment 6 Feng Qian 2009-01-13 17:33:24 PST 
Created attachment 26698 [details]
patch v4

Remove tab in the ChangeLog. Sorry for the trouble.
Comment 7 Darin Adler 2009-01-13 17:35:41 PST 
Comment on attachment 26698 [details]
patch v4

r=me
Comment 8 Brent Fulgham 2009-02-04 23:28:00 PST 
Committed in @r40668.