Bug 232935 - Fix racy parallel build of WebKit2-4.0.gir
Summary: Fix racy parallel build of WebKit2-4.0.gir
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2021-11-10 03:03 PST by Alexander Kanavin
Modified: 2022-02-21 17:44 PST (History)
9 users (show)

See Also:

Patch (2.80 KB, patch)
2021-11-10 03:05 PST, Alexander Kanavin
no flags Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2022-02-16 13:16 PST, Alexander Kanavin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kanavin 2021-11-10 03:03:54 PST
Fix racy parallel build of WebKit2-4.0.gir
Comment 1 Alexander Kanavin 2021-11-10 03:05:14 PST
Created attachment 443792 [details]
Comment 2 Radar WebKit Bug Importer 2021-11-17 03:04:23 PST
Comment 3 Michael Catanzaro 2022-02-16 13:06:30 PST
Comment on attachment 443792 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=443792&action=review

Oh wow, interesting.

LGTM. Maybe we'd want to use add custom_target() for all of these (including the ones in JavaScriptCore). Probably doesn't matter, but I'll defer to Don or Adrian for opinions on that.

> Source/WebKit/ChangeLog:8
> +        No new tests (OOPS!).

You need to remove this, then your patch will pass the style bot.
Comment 4 Alexander Kanavin 2022-02-16 13:16:41 PST
Created attachment 452239 [details]
Comment 5 Michael Catanzaro 2022-02-16 13:29:34 PST
Comment on attachment 452239 [details]

LGTM, will just wait a bit for any more comments. If nobody replies in the next couple days, please do ping again so we don't forget your patch.
Comment 6 Alexander Kanavin 2022-02-16 13:39:34 PST
By the way Michael, there was no indication at any point - in the documentation, or in the patch submission script - that I need to set 'component' to webkitgtk to get maintainer attention. I was starting to wonder why none of my submissions are moving forward. 

Perhaps there should be a bug to address this?

Tools/Scripts/webkit-patch upload

should both mention this.
Comment 7 Michael Catanzaro 2022-02-16 13:51:24 PST
Indeed, this is not a good trap, and not the first time it has happened.

In theory, it shouldn't be required because eventually somebody should notice the component is wrong and reassign it. In practice, we're drowning in bugs and that doesn't always happen....
Comment 8 EWS 2022-02-21 17:44:01 PST
Committed r290279 (247603@main): <https://commits.webkit.org/247603@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452239 [details].