Bug 232935 – Fix racy parallel build of WebKit2-4.0.gir

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alexander Kanavin]

Fix racy parallel build of WebKit2-4.0.gir

[Alexander Kanavin]

Created attachment 443792 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/85497279>

[Michael Catanzaro]

Comment on attachment 443792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443792&action=review

Oh wow, interesting.

LGTM. Maybe we'd want to use add custom_target() for all of these (including the ones in JavaScriptCore). Probably doesn't matter, but I'll defer to Don or Adrian for opinions on that.

> Source/WebKit/ChangeLog:8
> +        No new tests (OOPS!).

You need to remove this, then your patch will pass the style bot.

[Alexander Kanavin]

Created attachment 452239 [details]
Patch

[Michael Catanzaro]

Comment on attachment 452239 [details]
Patch

LGTM, will just wait a bit for any more comments. If nobody replies in the next couple days, please do ping again so we don't forget your patch.

[Alexander Kanavin]

By the way Michael, there was no indication at any point - in the documentation, or in the patch submission script - that I need to set 'component' to webkitgtk to get maintainer attention. I was starting to wonder why none of my submissions are moving forward. 

Perhaps there should be a bug to address this?

https://webkit.org/contributing-code/
Tools/Scripts/webkit-patch upload

should both mention this.

[Michael Catanzaro]

Indeed, this is not a good trap, and not the first time it has happened.

In theory, it shouldn't be required because eventually somebody should notice the component is wrong and reassign it. In practice, we're drowning in bugs and that doesn't always happen....

[EWS]

Committed r290279 (247603@main): <https://commits.webkit.org/247603@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452239 [details].