Currently the implicitly convert to bool leading bad results.
Created attachment 443782 [details] Patch
Comment on attachment 443782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443782&action=review > Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp:200 > + EXPECT_EQ(is32Bit ? zero32BitHash : zero64BitHash, computeHash(nullPtr)); maybe use just uintptr_t, not is32Bit
Comment on attachment 443782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443782&action=review > Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp:202 > + EXPECT_EQ(is32Bit ? computeHash(static_cast<uint32_t>(0xffffff)) : computeHash(static_cast<uint64_t>(0xffffff)), computeHash(ffffffPtr)); maybe test computeHash(nullptr) == computeHash(nullPtr)
Created attachment 443796 [details] Patch for landing
Committed r285572 (244080@main): <https://commits.webkit.org/244080@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443796 [details].
<rdar://problem/85250129>