WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
232909
[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
https://bugs.webkit.org/show_bug.cgi?id=232909
Summary
[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
Jer Noble
Reported
2021-11-09 15:23:48 PST
[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
Attachments
Patch
(22.99 KB, patch)
2021-11-09 17:25 PST
,
Jer Noble
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(24.48 KB, patch)
2021-11-09 19:54 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch for landing
(24.43 KB, patch)
2021-11-10 08:43 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch for landing
(24.43 KB, patch)
2021-11-10 08:44 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Follow up patch
(2.91 KB, patch)
2021-11-11 09:49 PST
,
Jer Noble
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Follow up patch
(3.29 KB, patch)
2021-11-11 10:22 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Follow up patch
(1.40 KB, patch)
2021-11-15 12:27 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2021-11-09 15:24:31 PST
<
rdar://68184444
>
Jer Noble
Comment 2
2021-11-09 17:25:57 PST
Created
attachment 443760
[details]
Patch
Jer Noble
Comment 3
2021-11-09 19:54:20 PST
Created
attachment 443770
[details]
Patch
Eric Carlson
Comment 4
2021-11-10 08:23:46 PST
Comment on
attachment 443770
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=443770&action=review
> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:195 > + if (proxy.gpuConnectionToWebProcess().presentingApplicationAuditToken()) > + presentingProcesses.append(*proxy.gpuConnectionToWebProcess().presentingApplicationAuditToken());
Nit: it would be more efficient, in a Debug build at least, to put the token into a local variable
Jer Noble
Comment 5
2021-11-10 08:43:27 PST
Created
attachment 443820
[details]
Patch for landing
EWS
Comment 6
2021-11-10 08:44:10 PST
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Jer Noble
Comment 7
2021-11-10 08:44:31 PST
Created
attachment 443821
[details]
Patch for landing
EWS
Comment 8
2021-11-10 09:32:50 PST
Committed
r285584
(
244092@main
): <
https://commits.webkit.org/244092@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 443821
[details]
.
Jer Noble
Comment 9
2021-11-11 09:49:50 PST
Reopening to attach new patch.
Jer Noble
Comment 10
2021-11-11 09:49:52 PST
Created
attachment 443959
[details]
Follow up patch
Chris Dumez
Comment 11
2021-11-11 09:53:46 PST
Comment on
attachment 443959
[details]
Follow up patch View in context:
https://bugs.webkit.org/attachment.cgi?id=443959&action=review
> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:172 > +#if HAVE(AUDIOSESSION_PROCESSASSERTION)
You want an #else with a UNUSED_PARAM(auditTokens);
Jer Noble
Comment 12
2021-11-11 10:22:57 PST
Created
attachment 443966
[details]
Follow up patch
Chris Dumez
Comment 13
2021-11-11 10:26:00 PST
Comment on
attachment 443966
[details]
Follow up patch r=me
EWS
Comment 14
2021-11-11 12:28:09 PST
Committed
r285646
(
244147@main
): <
https://commits.webkit.org/244147@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 443966
[details]
.
Jer Noble
Comment 15
2021-11-15 12:27:33 PST
Reopening to attach new patch.
Jer Noble
Comment 16
2021-11-15 12:27:35 PST
Created
attachment 444293
[details]
Follow up patch
EWS
Comment 17
2021-11-15 14:25:24 PST
Committed
r285836
(
244268@main
): <
https://commits.webkit.org/244268@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 444293
[details]
.
Maciej Stachowiak
Comment 18
2022-05-12 10:53:31 PDT
***
Bug 198277
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug