Bug 232898 - Add runtime flag for momentum scrolling animator
Summary: Add runtime flag for momentum scrolling animator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-09 11:45 PST by Tim Horton
Modified: 2021-11-09 13:06 PST (History)
12 users (show)

See Also:

Attachments
Patch (18.22 KB, patch)
2021-11-09 11:46 PST, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.18 KB, patch)
2021-11-09 11:59 PST, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.30 KB, patch)
2021-11-09 12:12 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-11-09 11:45:10 PST 
Add runtime flag for momentum scrolling
Comment 1 Tim Horton 2021-11-09 11:46:27 PST 
Created attachment 443712 [details]
Patch
Comment 2 Tim Horton 2021-11-09 11:46:31 PST 
<rdar://problem/85211338>
Comment 3 Simon Fraser (smfr) 2021-11-09 11:48:48 PST 
Comment on attachment 443712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443712&action=review

> Source/WebCore/page/scrolling/ScrollingStateNode.h:271
> +        MomentumScrollingAnimatorEnabled            = 1LLU << 44,

Can we move this up below AsyncFrameOrOverflowScrollingEnabled (and, yeah, change all the values).
Comment 4 Tim Horton 2021-11-09 11:55:06 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 443712 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443712&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingStateNode.h:271
> > +        MomentumScrollingAnimatorEnabled            = 1LLU << 44,
> 
> Can we move this up below AsyncFrameOrOverflowScrollingEnabled (and, yeah,
> change all the values).

Sure!
Comment 5 Tim Horton 2021-11-09 11:59:24 PST 
Created attachment 443714 [details]
Patch
Comment 6 Tim Horton 2021-11-09 12:12:32 PST 
Created attachment 443717 [details]
Patch
Comment 7 Tim Horton 2021-11-09 13:06:43 PST 
https://trac.webkit.org/changeset/285526/webkit