Bug 232863 - Fix wrong frame count of CARingBuffer in SpeechRecognitionRemoteRealtimeMediaSource
Summary: Fix wrong frame count of CARingBuffer in SpeechRecognitionRemoteRealtimeMedia...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-08 19:52 PST by Sihui Liu
Modified: 2021-11-09 13:36 PST (History)
10 users (show)

See Also:


Attachments
Patch (5.45 KB, patch)
2021-11-08 20:18 PST, Sihui Liu
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (1.14 KB, patch)
2021-11-09 13:34 PST, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-11-08 19:52:29 PST
...
Comment 1 Sihui Liu 2021-11-08 19:53:01 PST
<rdar://83381842>
Comment 2 Sihui Liu 2021-11-08 20:18:06 PST
Created attachment 443650 [details]
Patch
Comment 3 youenn fablet 2021-11-08 23:50:27 PST
Comment on attachment 443650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443650&action=review

> Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86
> +    m_description = description;

Do we need to set m_description here again, since we already set it when allocating m_ringBuffer?
It seems we should set m_description once and I would tend to do it in audioSamplesAvailable.
Comment 4 Sihui Liu 2021-11-09 09:06:26 PST
(In reply to youenn fablet from comment #3)
> Comment on attachment 443650 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443650&action=review
> 
> > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86
> > +    m_description = description;
> 
> Do we need to set m_description here again, since we already set it when
> allocating m_ringBuffer?
> It seems we should set m_description once and I would tend to do it in
> audioSamplesAvailable.

I don't understand. Do we set m_description elsewhere in SpeechRecognitionRemoteRealtimeMediaSource?

Do you mean m_description in SpeechRecognitionRealtimeMediaSourceManager::Source?
Comment 5 Sihui Liu 2021-11-09 10:47:12 PST
Comment on attachment 443650 [details]
Patch

Land the patch as it is to fix the bug first. Let me know if you think we should set m_description in a different place, and I will follow up.
Comment 6 EWS 2021-11-09 10:53:21 PST
Committed r285509 (244032@main): <https://commits.webkit.org/244032@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443650 [details].
Comment 7 Sihui Liu 2021-11-09 13:34:37 PST
Reopening to attach new patch.
Comment 8 Sihui Liu 2021-11-09 13:34:39 PST
Created attachment 443722 [details]
[fast-cq] Patch
Comment 9 Sihui Liu 2021-11-09 13:35:22 PST
Comment on attachment 443722 [details]
[fast-cq] Patch

Unreviewed build fix.
Comment 10 EWS 2021-11-09 13:36:56 PST
Committed r285531 (244048@main): <https://commits.webkit.org/244048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443722 [details].