...
<rdar://83381842>
Created attachment 443650 [details] Patch
Comment on attachment 443650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443650&action=review > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86 > + m_description = description; Do we need to set m_description here again, since we already set it when allocating m_ringBuffer? It seems we should set m_description once and I would tend to do it in audioSamplesAvailable.
(In reply to youenn fablet from comment #3) > Comment on attachment 443650 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443650&action=review > > > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86 > > + m_description = description; > > Do we need to set m_description here again, since we already set it when > allocating m_ringBuffer? > It seems we should set m_description once and I would tend to do it in > audioSamplesAvailable. I don't understand. Do we set m_description elsewhere in SpeechRecognitionRemoteRealtimeMediaSource? Do you mean m_description in SpeechRecognitionRealtimeMediaSourceManager::Source?
Comment on attachment 443650 [details] Patch Land the patch as it is to fix the bug first. Let me know if you think we should set m_description in a different place, and I will follow up.
Committed r285509 (244032@main): <https://commits.webkit.org/244032@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443650 [details].
Reopening to attach new patch.
Created attachment 443722 [details] [fast-cq] Patch
Comment on attachment 443722 [details] [fast-cq] Patch Unreviewed build fix.
Committed r285531 (244048@main): <https://commits.webkit.org/244048@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443722 [details].