WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
232855
BroadcastChannel is still disabled in service workers
https://bugs.webkit.org/show_bug.cgi?id=232855
Summary
BroadcastChannel is still disabled in service workers
Chris Dumez
Reported
2021-11-08 15:47:10 PST
BroadcastChannel is still disabled in service workers, despite it being enabled globally for WebKit2.
Attachments
Patch
(5.12 KB, patch)
2021-11-08 16:20 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(6.23 KB, patch)
2021-11-09 12:07 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2021-11-08 16:20:44 PST
Created
attachment 443627
[details]
Patch
Chris Dumez
Comment 2
2021-11-09 12:07:01 PST
Created
attachment 443716
[details]
Patch
Darin Adler
Comment 3
2021-11-09 13:49:32 PST
Comment on
attachment 443716
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=443716&action=review
> Source/WTF/ChangeLog:9 > + Turn on BroadcastChannel experimental feature in WebCore since this is the value that Service Workers > + end up using. We only need to disable it in WebKitLegacy.
It worries me a little to learn that Service Workers end up using a different set of features than the ones set by WebKit API. Makes me worry about our preferences machinery; is that really OK?
EWS
Comment 4
2021-11-09 14:20:03 PST
Committed
r285534
(
244051@main
): <
https://commits.webkit.org/244051@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 443716
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-11-09 14:21:21 PST
<
rdar://problem/85222916
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug