Bug 232851 - [Windows] Non-find based status file finding in run-jsc-stress-tests needs to release status files
Summary: [Windows] Non-find based status file finding in run-jsc-stress-tests needs to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-08 15:11 PST by Stephan Szabo
Modified: 2021-11-09 12:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2021-11-08 15:17 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-11-08 15:11:00 PST
Another patch wants to remove these files and we found that on (non-cygwin) Windows, they're being held by the non-find based status file searching. We didn't notice before since nothing else worked on these files after that.
Comment 1 Stephan Szabo 2021-11-08 15:17:28 PST
Created attachment 443616 [details]
Patch
Comment 2 Angelos Oikonomopoulos 2021-11-09 04:39:28 PST
This is a file descriptor leak anyway, great that you caught it.
Comment 3 EWS 2021-11-09 12:26:04 PST
Committed r285522 (244039@main): <https://commits.webkit.org/244039@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443616 [details].
Comment 4 Radar WebKit Bug Importer 2021-11-09 12:27:20 PST
<rdar://problem/85214916>