Bug 232848 – Factor platform specific code out of HTMLModelElement

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Factor platform specific code out of HTMLModelElement

[Sam Weinig]

Created attachment 443602 [details]
Patch

[Sam Weinig]

Created attachment 443609 [details]
Patch

[Sam Weinig]

Created attachment 443617 [details]
Patch

[Sam Weinig]

Created attachment 443621 [details]
Patch

[Sam Weinig]

Created attachment 443629 [details]
Patch

[Sam Weinig]

Created attachment 443632 [details]
Patch

[Sam Weinig]

Created attachment 443649 [details]
Patch

[Sam Weinig]

Created attachment 443693 [details]
Patch

[Sam Weinig]

Created attachment 443752 [details]
Patch

[Sam Weinig]

Created attachment 443849 [details]
Patch

[Dean Jackson]

Comment on attachment 443849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443849&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:225
> +    // FIXME: For the early returns here, we should probably inform the page that that things have

Typo: that that

> Source/WebKit/ChangeLog:9
> +        Move implementation details of the macOS AVKit <model> implementation
> +        into an AVKit model player implementation.

ARKit, not AVKit.

> Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayer.mm:98
> +    auto fileName = FileSystem::encodeForFileName(createCanonicalUUIDString()) + ".usdz";

Maybe use preferredExtensionForMIMEType? but i guess either way you're hardcoding USD.

[Sam Weinig]

Created attachment 443950 [details]
Patch

[Sam Weinig]

(In reply to Dean Jackson from comment #11)
> Comment on attachment 443849 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443849&action=review
> 
> > Source/WebCore/Modules/model-element/HTMLModelElement.cpp:225
> > +    // FIXME: For the early returns here, we should probably inform the page that that things have
> 
> Typo: that that

Fixed.

> 
> > Source/WebKit/ChangeLog:9
> > +        Move implementation details of the macOS AVKit <model> implementation
> > +        into an AVKit model player implementation.
> 
> ARKit, not AVKit.

Eek. Fixed. 

> 
> > Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayer.mm:98
> > +    auto fileName = FileSystem::encodeForFileName(createCanonicalUUIDString()) + ".usdz";
> 
> Maybe use preferredExtensionForMIMEType? but i guess either way you're
> hardcoding USD.

I didn't change this one, because it was just moved code and this all needs to be removed anyway.

[EWS]

Committed r285637 (244138@main): <https://commits.webkit.org/244138@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443950 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85304945>