232838 – Parse redirect and modify-headers actions for WKContentRuleList

Bug 232838 - Parse redirect and modify-headers actions for WKContentRuleList

Summary: Parse redirect and modify-headers actions for WKContentRuleList

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2021-11-08 12:49 PST by Alex Christensen
Modified:	2021-11-08 16:19 PST (History)
CC List:	14 users (show)

See Also:

Attachments
Patch (51.03 KB, patch) 2021-11-08 12:50 PST, Alex Christensen	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
Patch (77.78 KB, patch) 2021-11-08 14:59 PST, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (78.23 KB, patch) 2021-11-08 15:16 PST, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2021-11-08 12:49:18 PST

Parse redirect and modify-headers actions for WKContentRuleList

Comment 1 Alex Christensen 2021-11-08 12:50:48 PST Comment hidden (obsolete)

Created attachment 443591 [details]
Patch

Comment 2 Alex Christensen 2021-11-08 14:59:42 PST

Created attachment 443613 [details]
Patch

Comment 3 Timothy Hatcher 2021-11-08 15:02:47 PST Comment hidden (obsolete)

Comment on attachment 443591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443591&action=review

> Source/WebCore/contentextensions/ContentExtensionError.cpp:97
> +                return "add-or-replace-parameters value must be an array";

"A add-or-replace-parameters value…" to match the other errors.

Comment 4 Timothy Hatcher 2021-11-08 15:04:25 PST

Comment on attachment 443613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443613&action=review

> Source/WebCore/contentextensions/ContentExtensionError.cpp:95
> +                return "add-or-replace-parameters value must be an array";

"A add-or-replace-parameters value…" to match the other errors.

Comment 5 Alex Christensen 2021-11-08 15:16:10 PST

Created attachment 443615 [details]
Patch

Comment 6 Alex Christensen 2021-11-08 16:18:31 PST

https://trac.webkit.org/changeset/285443/webkit

Comment 7 Radar WebKit Bug Importer 2021-11-08 16:19:22 PST

<rdar://problem/85178198>