RESOLVED FIXED 232830
Re-use isCSSWideKeyword in CSSVariableParser.cpp & CSSPropertyParser.cpp 
https://bugs.webkit.org/show_bug.cgi?id=232830
Summary Re-use isCSSWideKeyword in CSSVariableParser.cpp & CSSPropertyParser.cpp
Tim Nguyen (:ntim)
Reported 2021-11-08 12:02:51 PST
Sub-set of bug 224816
Attachments
Patch (2.44 KB, patch)
2021-11-08 12:09 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-11-08 12:09:20 PST
Created attachment 443584 [details] Patch
Antti Koivisto
Comment 2 2021-11-08 23:46:53 PST
Comment on attachment 443584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443584&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:4568 > - CSSValueID id = m_range.peek().id(); > - if (id == CSSValueInherit || id == CSSValueInitial || id == CSSValueRevert) > + if (isCSSWideKeyword(m_range.peek().id())) Can we make a test for this?
Tim Nguyen (:ntim)
Comment 3 2021-11-09 00:12:16 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 443584 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443584&action=review > > > Source/WebCore/css/parser/CSSPropertyParser.cpp:4568 > > - CSSValueID id = m_range.peek().id(); > > - if (id == CSSValueInherit || id == CSSValueInitial || id == CSSValueRevert) > > + if (isCSSWideKeyword(m_range.peek().id())) > > Can we make a test for this? I don't see any easily extendable test in https://github.com/web-platform-tests/wpt/tree/master/css/css-properties-values-api unfortunately, or similar test for the matter.
EWS
Comment 4 2021-11-09 00:16:00 PST
Committed r285483 (244007@main): <https://commits.webkit.org/244007@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443584 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-09 00:17:21 PST
<rdar://problem/85191933>
Darin Adler
Comment 6 2021-11-09 14:18:07 PST
Comment on attachment 443584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443584&action=review >>> Source/WebCore/css/parser/CSSPropertyParser.cpp:4568 >>> + if (isCSSWideKeyword(m_range.peek().id())) >> >> Can we make a test for this? > > I don't see any easily extendable test in https://github.com/web-platform-tests/wpt/tree/master/css/css-properties-values-api unfortunately, or similar test for the matter. Is this a behavior change, because we now check for "unset" as well? But not testable?
Note You need to log in before you can comment on or make changes to this bug.