Bug 232805 - Fix the CGEvent types used for wheel event generation from streams
Summary: Fix the CGEvent types used for wheel event generation from streams
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-07 20:40 PST by Simon Fraser (smfr)
Modified: 2021-11-08 10:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.68 KB, patch)
2021-11-07 20:43 PST, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-11-07 20:40:41 PST
Fix the CGEvent types used for wheel event generation from streams
Comment 1 Simon Fraser (smfr) 2021-11-07 20:43:54 PST
Created attachment 443524 [details]
Patch
Comment 2 Sam Weinig 2021-11-08 08:36:42 PST
Comment on attachment 443524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443524&action=review

> Tools/ChangeLog:10
> +        The set of enum values for wheel event types are confusing, and I used the wrong ones in
> +        r285390, so fix that. Values are all the same other than kCGMomentumScrollPhaseEnd which is
> +        now correct.

Is the end phase being different detectable?
Comment 3 Simon Fraser (smfr) 2021-11-08 09:27:32 PST
(In reply to Sam Weinig from comment #2)
> Comment on attachment 443524 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443524&action=review
> 
> > Tools/ChangeLog:10
> > +        The set of enum values for wheel event types are confusing, and I used the wrong ones in
> > +        r285390, so fix that. Values are all the same other than kCGMomentumScrollPhaseEnd which is
> > +        now correct.
> 
> Is the end phase being different detectable?

I don't think it is currently. Since this is new test infrastructure I didn't try to make a regression test for that.
Comment 4 Simon Fraser (smfr) 2021-11-08 09:59:55 PST
https://trac.webkit.org/changeset/285409/webkit
Comment 5 Radar WebKit Bug Importer 2021-11-08 10:00:24 PST
<rdar://problem/85160514>