Bug 232802 - Enabling "media source inline painting" by default should work when using GPU Process for media
Summary: Enabling "media source inline painting" by default should work when using GPU...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-07 16:57 PST by Wenson Hsieh
Modified: 2021-11-08 09:59 PST (History)
5 users (show)

See Also:

Attachments
For EWS (9.97 KB, patch)
2021-11-07 17:06 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix minor typo (9.96 KB, patch)
2021-11-07 17:07 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-11-07 16:57:23 PST 
.
Comment 1 Wenson Hsieh 2021-11-07 17:06:12 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-11-07 17:07:51 PST 
Created attachment 443522 [details]
Fix minor typo
Comment 3 Wenson Hsieh 2021-11-08 09:17:53 PST 
Comment on attachment 443522 [details]
Fix minor typo

View in context: https://bugs.webkit.org/attachment.cgi?id=443522&action=review

Thanks for the review!

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:612
> +    // FIXME: Additionally, it seems wrong to consult preferences on WebPageGroup rather than WebPreferences corresponding to each page.

(FYI): I'm working on a followup patch here that will address this FIXME, and make it possible to use the experimental features menu to toggle mediaSourceInlinePaintingEnabled (as well as opusDecoderEnabled, vorbisDecoderEnabled, etc.) when using GPUP for media.
Comment 4 EWS 2021-11-08 09:58:05 PST 
Committed r285410 (243967@main): <https://commits.webkit.org/243967@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443522 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-08 09:59:20 PST 
<rdar://problem/85160450>