Bug 23280 - Move defaultUnitsPerEm to SimpleFontData
Summary: Move defaultUnitsPerEm to SimpleFontData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 16:04 PST by Dimitri Glazkov (Google)
Modified: 2009-01-13 14:24 PST (History)
0 users

See Also:

Attachments
v1 submitted for review (1.50 KB, patch)
2009-01-12 16:31 PST, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-01-12 16:04:18 PST 
Bug 22936 introduced defaultUnitsPerEm constant to SVGFontFaceElement.h. The trouble is, this constant was used in SimpleFontData, which made non-SVG-enabled builds break.
Comment 1 Dimitri Glazkov (Google) 2009-01-12 16:31:55 PST 
Created attachment 26655 [details]
v1 submitted for review

 WebCore/ChangeLog                          |   11 +++++++++++
 WebCore/platform/graphics/SimpleFontData.h |    2 ++
 WebCore/svg/SVGFontFaceElement.cpp         |    1 +
 3 files changed, 14 insertions(+), 0 deletions(-)
Comment 2 Mark Rowe (bdash) 2009-01-12 17:05:05 PST 
Is this still needed after <http://trac.webkit.org/changeset/39843>?
Comment 3 Dimitri Glazkov (Google) 2009-01-12 20:17:23 PST 
Gah! Changeset collision. Sparks fly!

Ok, I think his solution is fine, too. Closing this one.
Comment 4 Eric Seidel (no email) 2009-01-13 14:24:31 PST 
Comment on attachment 26655 [details]
v1 submitted for review

clearing review flag.  silly bugzilla.