RESOLVED FIXED 23280
Move defaultUnitsPerEm to SimpleFontData 
https://bugs.webkit.org/show_bug.cgi?id=23280
Summary Move defaultUnitsPerEm to SimpleFontData
Dimitri Glazkov (Google)
Reported 2009-01-12 16:04:18 PST
Bug 22936 introduced defaultUnitsPerEm constant to SVGFontFaceElement.h. The trouble is, this constant was used in SimpleFontData, which made non-SVG-enabled builds break.
Attachments
v1 submitted for review (1.50 KB, patch)
2009-01-12 16:31 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-01-12 16:31:55 PST
Created attachment 26655 [details] v1 submitted for review WebCore/ChangeLog | 11 +++++++++++ WebCore/platform/graphics/SimpleFontData.h | 2 ++ WebCore/svg/SVGFontFaceElement.cpp | 1 + 3 files changed, 14 insertions(+), 0 deletions(-)
Mark Rowe (bdash)
Comment 2 2009-01-12 17:05:05 PST
Is this still needed after <http://trac.webkit.org/changeset/39843>?
Dimitri Glazkov (Google)
Comment 3 2009-01-12 20:17:23 PST
Gah! Changeset collision. Sparks fly! Ok, I think his solution is fine, too. Closing this one.
Eric Seidel (no email)
Comment 4 2009-01-13 14:24:31 PST
Comment on attachment 26655 [details] v1 submitted for review clearing review flag. silly bugzilla.
Note You need to log in before you can comment on or make changes to this bug.