Bug 232797 - Use narrower types for style scope ordinal and cascade layer priority
Summary: Use narrower types for style scope ordinal and cascade layer priority
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on: 232828 232930
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-07 01:22 PST by Antti Koivisto
Modified: 2021-11-11 00:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.09 KB, patch)
2021-11-07 01:30 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (8.56 KB, patch)
2021-11-07 07:38 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2021-11-07 07:41 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (8.54 KB, patch)
2021-11-10 23:07 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (8.53 KB, patch)
2021-11-10 23:14 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-11-07 01:22:50 PST 
Shrink some critical style related data structures.
Comment 1 Antti Koivisto 2021-11-07 01:30:05 PST 
Created attachment 443502 [details]
Patch
Comment 2 Antti Koivisto 2021-11-07 07:38:48 PST 
Created attachment 443508 [details]
Patch
Comment 3 Antti Koivisto 2021-11-07 07:41:56 PST 
Created attachment 443509 [details]
Patch
Comment 4 EWS 2021-11-07 10:58:19 PST 
Committed r285392 (243949@main): <https://commits.webkit.org/243949@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443509 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-07 10:59:20 PST 
<rdar://problem/85126679>
Comment 6 WebKit Commit Bot 2021-11-08 11:42:14 PST 
Re-opened since this is blocked by bug 232828
Comment 7 Ryan Haddad 2021-11-08 11:48:12 PST 
This change appears to have caused a layout test regression, would be good to investigate before re-landing: https://bugs.webkit.org/show_bug.cgi?id=232827
Comment 8 Antti Koivisto 2021-11-10 23:07:30 PST 
Created attachment 443915 [details]
Patch for landing
Comment 9 EWS 2021-11-10 23:08:31 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 10 Antti Koivisto 2021-11-10 23:14:08 PST 
Created attachment 443916 [details]
Patch for landing
Comment 11 EWS 2021-11-11 00:21:58 PST 
Committed r285622 (244123@main): <https://commits.webkit.org/244123@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443916 [details].