Bug 232795 - restore canvas WPTs removed in bug 232449
Summary: restore canvas WPTs removed in bug 232449
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on: 232449
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-06 22:53 PDT by Cameron McCormack (:heycam)
Modified: 2021-11-07 15:07 PST (History)
11 users (show)

See Also:


Attachments
Patch (1.09 MB, patch)
2021-11-06 22:56 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (1.09 MB, patch)
2021-11-07 13:02 PST, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-11-06 22:53:32 PDT
I think the WPT updating script sometimes has trouble with directories named "manual" -- maybe it considers it a directory of manual tests, which by default are not imported?  The WPT updating in bug 232449 inadvertently removed a bunch of canvas tests under a "manual" directory, which aren't manual tests.
Comment 1 Radar WebKit Bug Importer 2021-11-06 22:54:02 PDT
<rdar://problem/85108161>
Comment 2 Cameron McCormack (:heycam) 2021-11-06 22:56:29 PDT
Created attachment 443500 [details]
Patch
Comment 3 Ryosuke Niwa 2021-11-06 23:46:01 PDT
Comment on attachment 443500 [details]
Patch

rs=me
Comment 4 EWS 2021-11-07 00:45:19 PDT
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Cameron McCormack (:heycam) 2021-11-07 13:02:53 PST
Created attachment 443519 [details]
[fast-cq] Patch
Comment 6 EWS 2021-11-07 13:13:35 PST
Committed r285394 (243951@main): <https://commits.webkit.org/243951@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443519 [details].
Comment 7 Chris Dumez 2021-11-07 15:07:57 PST
(In reply to Cameron McCormack (:heycam) from comment #0)
> I think the WPT updating script sometimes has trouble with directories named
> "manual" -- maybe it considers it a directory of manual tests, which by
> default are not imported?  The WPT updating in bug 232449 inadvertently
> removed a bunch of canvas tests under a "manual" directory, which aren't
> manual tests.

Oh, it wasn’t the importer, it was me. I saw a folder named manual so I removed it since we don’t care about manual tests.

Sorry if this was a mistake. Maybe this folder should be named differently if it doesn’t contain manual tests.