Bug 23279 - [GTK] fix crash after WebView dispose
Summary: [GTK] fix crash after WebView dispose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 15:53 PST by Alexander Butenko
Modified: 2009-01-13 11:57 PST (History)
0 users

See Also:

Attachments
patch (1.03 KB, patch)
2009-01-12 15:58 PST, Alexander Butenko 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Butenko 2009-01-12 15:53:30 PST 
Bug is related to #23194. 

The WebCore::Page is deleted by the dispose implementation and webkit_web_view_set_scroll_adjustments() doesn't check is Page still exist.
Mischeck leads to a crash sometimes.
Comment 1 Alexander Butenko 2009-01-12 15:58:24 PST 
Created attachment 26653 [details]
patch
Comment 2 Holger Freyther 2009-01-13 03:35:45 PST 
Looks good. I have this as well:

@@ -883,6 +887,9 @@ static gboolean webkit_navigation_request_handled(GSignalInvocationHint* ihint,
 static AtkObject* webkit_web_view_get_accessible(GtkWidget* widget)
 {
     WebKitWebView* webView = WEBKIT_WEB_VIEW(widget);
+    if (!core(webView))
+        return NULL;
+
Comment 3 Holger Freyther 2009-01-13 06:29:11 PST 
Comment on attachment 26653 [details]
patch

I will land this with the atk hunk from the comments. there was mutual agreement on #webkit-gtk on this issue.
Comment 4 Holger Freyther 2009-01-13 11:57:47 PST 
Landed in r39855.