RESOLVED FIXED 23279
[GTK] fix crash after WebView dispose 
https://bugs.webkit.org/show_bug.cgi?id=23279
Summary [GTK] fix crash after WebView dispose
Alexander Butenko
Reported Monday, January 12, 2009 11:53:30 PM UTC
Bug is related to #23194. The WebCore::Page is deleted by the dispose implementation and webkit_web_view_set_scroll_adjustments() doesn't check is Page still exist. Mischeck leads to a crash sometimes.
Attachments
patch (1.03 KB, patch)
2009-01-12 15:58 PST, Alexander Butenko 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Butenko
Comment 1 Monday, January 12, 2009 11:58:24 PM UTC
Created attachment 26653 [details] patch
Holger Freyther
Comment 2 Tuesday, January 13, 2009 11:35:45 AM UTC
Looks good. I have this as well: @@ -883,6 +887,9 @@ static gboolean webkit_navigation_request_handled(GSignalInvocationHint* ihint, static AtkObject* webkit_web_view_get_accessible(GtkWidget* widget) { WebKitWebView* webView = WEBKIT_WEB_VIEW(widget); + if (!core(webView)) + return NULL; +
Holger Freyther
Comment 3 Tuesday, January 13, 2009 2:29:11 PM UTC
Comment on attachment 26653 [details] patch I will land this with the atk hunk from the comments. there was mutual agreement on #webkit-gtk on this issue.
Holger Freyther
Comment 4 Tuesday, January 13, 2009 7:57:47 PM UTC
Landed in r39855.
Note You need to log in before you can comment on or make changes to this bug.