Bug 232783 - Import css/css-sizing/aspect-ratio tests from WPT
Summary: Import css/css-sizing/aspect-ratio tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-06 02:58 PDT by Rob Buis
Modified: 2021-11-09 09:56 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.17 KB, patch)
2021-11-06 03:01 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (15.08 KB, patch)
2021-11-09 07:43 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (13.93 KB, patch)
2021-11-09 08:58 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-11-06 02:58:24 PDT
Import css/css-sizing/aspect-ratio tests from WPT.
Comment 1 Rob Buis 2021-11-06 03:01:03 PDT
Created attachment 443480 [details]
Patch
Comment 2 Rob Buis 2021-11-09 07:43:35 PST
Created attachment 443690 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2021-11-09 08:39:42 PST
Comment on attachment 443690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443690&action=review

r=me, but wait for green EWSs before landing.

> LayoutTests/imported/w3c/resources/import-expectations.json:324
> +    "web-platform-tests/html/semantics/interactive-elements/the-summary-element": "skip", 

This change seems unrelated.
Comment 4 Rob Buis 2021-11-09 08:58:03 PST
Created attachment 443695 [details]
Patch
Comment 5 EWS 2021-11-09 09:55:47 PST
Committed r285505 (244029@main): <https://commits.webkit.org/244029@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443695 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-09 09:56:21 PST
<rdar://problem/85207556>