Bug 232772 - [LFC][IFC] Process all replacement, control and opaque inline items.
Summary: [LFC][IFC] Process all replacement, control and opaque inline items.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-05 15:48 PDT by zalan
Modified: 2021-11-06 12:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.33 KB, patch)
2021-11-05 15:54 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.56 KB, patch)
2021-11-05 21:42 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.67 KB, patch)
2021-11-06 09:58 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-11-05 15:48:48 PDT 
generate bidi level for all the inline items.
Comment 1 zalan 2021-11-05 15:54:26 PDT 
Created attachment 443451 [details]
Patch
Comment 2 zalan 2021-11-05 21:42:55 PDT 
Created attachment 443476 [details]
Patch
Comment 3 Antti Koivisto 2021-11-06 06:35:44 PDT 
Comment on attachment 443476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443476&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:147
> +    size_t inlineTextBoxOffset = 0;
> +    for (size_t index = 0; index < inlineItems.size(); ++index) {

Could we reserverInitialCapacity() for InlineItemOffsetList and then use uncheckedAppend?
Comment 4 zalan 2021-11-06 06:42:24 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 443476 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443476&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:147
> > +    size_t inlineTextBoxOffset = 0;
> > +    for (size_t index = 0; index < inlineItems.size(); ++index) {
> 
> Could we reserverInitialCapacity() for InlineItemOffsetList and then use
> uncheckedAppend?
Good point! Will do.
Comment 5 zalan 2021-11-06 09:58:38 PDT 
Created attachment 443487 [details]
Patch
Comment 6 EWS 2021-11-06 12:41:26 PDT 
Committed r285374 (243931@main): <https://commits.webkit.org/243931@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443487 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-06 12:42:17 PDT 
<rdar://problem/85103505>