Bug 232769 - [iOS] IPC decoder for ResourceRequest loses systemPreviewInfo when there is platform data
Summary: [iOS] IPC decoder for ResourceRequest loses systemPreviewInfo when there is p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 231727
  Show dependency tree / graph
 
Reported: 2021-11-05 15:23 PDT by Chris Dumez
Modified: 2021-11-07 01:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2021-11-05 15:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2021-11-05 17:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-05 15:23:02 PDT 
The IPC decoder for ResourceRequest decoders systemPreviewInfo and sets it on the ResourceRequest. It then uses different code paths to decode the rest of the ResourceRequest based on whether or not there is underlying platform data.
If there is underlying platform data, we call decodePlatformData() which creates a brand-new ResourceRequest, and thus looses the systemPreviewInfo we've just set.
Comment 1 Chris Dumez 2021-11-05 15:46:51 PDT 
Created attachment 443448 [details]
Patch
Comment 2 Wenson Hsieh 2021-11-05 16:58:08 PDT 
Comment on attachment 443448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443448&action=review

> Source/WebKit/ChangeLog:8
> +        The IPC decoder for ResourceRequest decoders systemPreviewInfo and sets it on the ResourceRequest.

Nit - s/decoders/decodes/

> Source/WebKit/ChangeLog:11
> +        which creates a brand-new ResourceRequest, and thus looses the systemPreviewInfo we've just set.

Nit - s/looses/loses/
Comment 3 Chris Dumez 2021-11-05 17:11:51 PDT 
Created attachment 443459 [details]
Patch
Comment 4 EWS 2021-11-05 20:03:04 PDT 
Committed r285361 (243919@main): <https://commits.webkit.org/243919@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443459 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-05 20:04:18 PDT 
<rdar://problem/85094542>