Bug 232740 - Infinite loop in SourceBufferParserWebM::SegmentReader::Read
Summary: Infinite loop in SourceBufferParserWebM::SegmentReader::Read
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks: 234496
  Show dependency tree / graph
 
Reported: 2021-11-04 17:44 PDT by Jer Noble
Modified: 2021-12-19 19:14 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.62 KB, patch)
2021-11-04 17:56 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (8.64 KB, patch)
2021-11-05 09:19 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (9.05 KB, patch)
2021-11-05 09:40 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (10.27 KB, patch)
2021-11-05 10:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-11-04 17:44:23 PDT 
Infinite loop in SourceBufferParserWebM::SegmentReader::Read
Comment 1 Jer Noble 2021-11-04 17:54:06 PDT 
<rdar://83573873>
Comment 2 Jer Noble 2021-11-04 17:56:04 PDT 
Created attachment 443364 [details]
Patch
Comment 3 Eric Carlson 2021-11-05 09:12:03 PDT 
Comment on attachment 443364 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443364&action=review

r=me once the bots can deal with it

> Source/WebCore/ChangeLog:13
> +        MTPluginByteSourceRead() call is failing and returning an error. When an error occurrs, the

s/occurrs/occurs/

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:313
> +            if (!readResult)

I thinks "!readResult.has_value()", like you use above, is clearer.

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:406
> +                if (!readResult)

Ditto
Comment 4 Jer Noble 2021-11-05 09:19:18 PDT 
Created attachment 443402 [details]
Patch for landing
Comment 5 Jer Noble 2021-11-05 09:40:42 PDT 
Created attachment 443407 [details]
Patch for landing
Comment 6 Jer Noble 2021-11-05 10:20:35 PDT 
Created attachment 443413 [details]
Patch for landing
Comment 7 EWS 2021-11-08 08:19:36 PST 
Committed r285402 (243959@main): <https://commits.webkit.org/243959@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443413 [details].