Bug 232711 - AX: rename actionVerb() as localizedActionVerb()
Summary: AX: rename actionVerb() as localizedActionVerb()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2021-11-04 06:48 PDT by Carlos Garcia Campos
Modified: 2021-11-05 01:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch (13.03 KB, patch)
2021-11-04 06:51 PDT, Carlos Garcia Campos 		andresg_22: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-11-04 06:48:28 PDT 
Since it's returning the localized name. In ATSPI there are two methods in the action interface GetName and GetLocalizedName so we need both.
Comment 1 Radar WebKit Bug Importer 2021-11-04 06:48:42 PDT 
<rdar://problem/85015496>
Comment 2 Carlos Garcia Campos 2021-11-04 06:51:08 PDT 
Created attachment 443301 [details]
Patch
Comment 3 Andres Gonzalez 2021-11-04 07:16:00 PDT 
(In reply to Carlos Garcia Campos from comment #2)
> Created attachment 443301 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
+++ a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

-String AccessibilityRenderObject::actionVerb() const
...

So this was duplicated in the subclass? Thanks for cleaning that up!
Comment 4 Carlos Garcia Campos 2021-11-04 07:21:47 PDT 
(In reply to Andres Gonzalez from comment #3)
> (In reply to Carlos Garcia Campos from comment #2)
> > Created attachment 443301 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
> +++ a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
> 
> -String AccessibilityRenderObject::actionVerb() const
> ...
> 
> So this was duplicated in the subclass? Thanks for cleaning that up!

Yes, almost duplicated, the base class handles menu actions too.
Comment 5 Carlos Garcia Campos 2021-11-05 01:23:49 PDT 
Committed r285340 (243901@main): <https://commits.webkit.org/243901@main>