Bug 232694 - [fast-cq] Require MediaSessionCoordinator enabled to enable MediaSession PlayList API
Summary: [fast-cq] Require MediaSessionCoordinator enabled to enable MediaSession Play...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-03 21:07 PDT by Diego Pino
Modified: 2021-11-04 05:38 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2021-11-03 21:07 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2021-11-03 21:14 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (4.15 KB, patch)
2021-11-03 23:53 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-11-03 21:07:08 PDT 
Require MediaSession enabled to enable MediaSession PlayList API
Comment 1 Diego Pino 2021-11-03 21:07:35 PDT 
Created attachment 443269 [details]
Patch
Comment 2 Diego Pino 2021-11-03 21:14:25 PDT 
Created attachment 443270 [details]
Patch
Comment 3 Diego Pino 2021-11-03 21:22:29 PDT 
r285241 enabled MediaSession PlayList API on the condition `WebKit::defaultMediaSessionCoordinatorEnabled()`, but definition of that function is guarded by ENABLE(MEDIA_SESSION_COORDINATOR) (https://webkit-search.igalia.com/webkit/source/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp#333). The flag is disabled in WebKitGTK/WPE (https://webkit-search.igalia.com/webkit/source/Source/cmake/WebKitFeatures.cmake#171), which caused r285241 to break compilation in WebKitGTK/WPE.

https://build.webkit.org/#/builders/41/builds/7221

```
/app/webkit/WebKitBuild/Release/DerivedSources/WebKit/WebPreferencesDefinitions.h:621:63: error: ‘defaultMediaSessionCoordinatorEnabled’ is not a member of ‘WebKit’
  621 | #define DEFAULT_VALUE_FOR_MediaSessionPlaylistEnabled WebKit::defaultMediaSessionCoordinatorEnabled()
      |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Comment 4 Diego Pino 2021-11-03 23:53:51 PDT 
Created attachment 443278 [details]
Patch
Comment 5 EWS 2021-11-04 05:36:59 PDT 
Committed r285260 (243871@main): <https://commits.webkit.org/243871@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443278 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-04 05:38:19 PDT 
<rdar://problem/85014283>