Bug 232690 - [Cocoa] Migrate from CTFontCopyVariationAxes() to CTFontCopyVariationAxesInternal() if possible
Summary: [Cocoa] Migrate from CTFontCopyVariationAxes() to CTFontCopyVariationAxesInte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 232894
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-03 16:59 PDT by Myles C. Maxfield
Modified: 2021-11-09 17:58 PST (History)
12 users (show)

See Also:

Attachments
Patch (16.78 KB, patch)
2021-11-03 17:01 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.56 KB, patch)
2021-11-03 21:23 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2021-11-03 21:25 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.92 KB, patch)
2021-11-03 21:31 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (8.13 KB, patch)
2021-11-03 21:33 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (16.67 KB, patch)
2021-11-04 00:08 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-11-03 16:59:10 PDT 
[Cocoa] Migrate from CTFontCopyVariationAxes() to CTFontCopyVariationAxesInternal() if possible
Comment 1 Myles C. Maxfield 2021-11-03 17:01:12 PDT 
Created attachment 443255 [details]
Patch
Comment 2 Myles C. Maxfield 2021-11-03 21:23:34 PDT 
Created attachment 443271 [details]
Patch
Comment 3 Myles C. Maxfield 2021-11-03 21:25:24 PDT 
Created attachment 443272 [details]
Patch
Comment 4 Myles C. Maxfield 2021-11-03 21:31:15 PDT 
Created attachment 443273 [details]
Patch
Comment 5 Myles C. Maxfield 2021-11-03 21:33:56 PDT 
Created attachment 443275 [details]
Patch
Comment 6 Myles C. Maxfield 2021-11-04 00:08:43 PDT 
Created attachment 443279 [details]
Patch
Comment 7 Simon Fraser (smfr) 2021-11-04 14:06:44 PDT 
Comment on attachment 443279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:35
> +enum class ShouldLocalizeAxisNames : uint8_t {
> +    No,
> +    Yes
> +};

Is there a reason this can't just live in FontPlatformData.h?
Comment 8 Cameron McCormack (:heycam) 2021-11-04 14:08:05 PDT 
Comment on attachment 443279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

2021 (if you don't end up moving it)

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:305
> +#if defined(HAVE_CTFontCopyVariationAxesInternal) // This macro is defined inside CoreText, not WebKit.

Thanks for the comment otherwise I would've complained about the capitalization here. :-)
Comment 9 Myles C. Maxfield 2021-11-04 16:18:32 PDT 
Committed r285318 (243890@main): <https://commits.webkit.org/243890@main>
Comment 10 Myles C. Maxfield 2021-11-04 16:19:05 PDT 
Comment on attachment 443279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

>> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:35
>> +};
> 
> Is there a reason this can't just live in FontPlatformData.h?

I would have preferred to put this in a common place, but this has to be visible from both FontPlatformData.h and FontCacheCoreText.h. There is no header (that isn't single-purpose like FontTaggedSettings.h or FontSelectionAlgorithm.h) which is included from both of those places.
Comment 11 Radar WebKit Bug Importer 2021-11-04 16:19:29 PDT 
<rdar://problem/85038305>
Comment 12 WebKit Commit Bot 2021-11-09 11:02:34 PST 
Re-opened since this is blocked by bug 232894
Comment 13 Myles C. Maxfield 2021-11-09 17:58:16 PST 
Committed r285552 (244066@main): <https://commits.webkit.org/244066@main>