Bug 232689 - Crash when opening and closing color picker while resetting form
Summary: Crash when opening and closing color picker while resetting form
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-03 16:34 PDT by Aditya Keerthi
Modified: 2021-11-04 13:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.11 KB, patch)
2021-11-03 16:36 PDT, Aditya Keerthi 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing (5.11 KB, patch)
2021-11-03 16:51 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-11-03 16:34:10 PDT 
...
Comment 1 Aditya Keerthi 2021-11-03 16:34:26 PDT 
rdar://84979791
Comment 2 Aditya Keerthi 2021-11-03 16:36:50 PDT 
Created attachment 443252 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-11-03 16:40:04 PDT 
Comment on attachment 443252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443252&action=review

> LayoutTests/fast/forms/color/color-input-reset-crash.html:27
> +    await UIHelper.delayFor(interval);

Can we make this test take less than 1000ms?
Comment 4 Aditya Keerthi 2021-11-03 16:51:11 PDT 
Created attachment 443254 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-11-03 16:52:10 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 443252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443252&action=review
> 
> > LayoutTests/fast/forms/color/color-input-reset-crash.html:27
> > +    await UIHelper.delayFor(interval);
> 
> Can we make this test take less than 1000ms?

Reduced to 100ms, after verifying the test still fails without the fix.
Comment 6 EWS 2021-11-04 13:35:54 PDT 
Committed r285306 (243885@main): <https://commits.webkit.org/243885@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443254 [details].