Bug 232671 – [Catalina] HLS streams will not select HDR variants when GPU Process is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

[Catalina] HLS streams will not select HDR variants when GPU Process is enabled

[Jer Noble]

<rdar://84686676>

[Jer Noble]

Created attachment 443212 [details]
Patch

[Eric Carlson]

Comment on attachment 443212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443212&action=review

> Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:88
> +    if (hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)) {

Nit: this comment is confusing, does "hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)" imply AVPlayer.videoRangeOverride isn't present?

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 443212 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443212&action=review
> 
> > Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:88
> > +    if (hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)) {
> 
> Nit: this comment is confusing, does
> "hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)"
> imply AVPlayer.videoRangeOverride isn't present?


No, it's the `#if !HAVE(AVPLAYER_VIDEORANGEOVERRIDE` above that does that. I can move the comment around.

[Jer Noble]

Created attachment 443224 [details]
Patch for landing

[EWS]

Committed r285219 (243844@main): <https://commits.webkit.org/243844@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443224 [details].

[Per Arne Vollan]

Comment on attachment 443224 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=443224&action=review

> Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:94
> +    // This override is not necessary if AVFoundation is allowed to communicate
> +    // with the window server to query for HDR support.
> +    if (hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)) {
> +        setShouldOverrideScreenSupportsHighDynamicRange(false, false);
> +        return;
> +    }

This piece might not be needed, since I think hasProcessPrivilege will always return false in the GPU process for this privilege.