Bug 232659 - Release+assert build broken due to ColorTypes.h assertInRange
Summary: Release+assert build broken due to ColorTypes.h assertInRange
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-03 02:17 PDT by Kimmo Kinnunen
Modified: 2021-11-10 01:18 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-11-03 02:17:25 PDT 
Release+assert build broken due to ColorTypes.h assertInRange

assertInRange cannot be constexpr due to it using ASSERT. Conceptually if it fails, we don't want the compiler to assert.

ColorSpace.h starts a call chain that invokes the assertInRange in non-constexpr context, so the assert cannot be static_assert.


make ra
Comment 1 Kimmo Kinnunen 2021-11-03 02:32:33 PDT 
also: callWithColorType std::invoke is not constexpr in c++17.
Comment 2 Radar WebKit Bug Importer 2021-11-10 01:18:21 PST 
<rdar://problem/85244408>